Team2890/PhotonVision
4
0
Fork 0
mirror of https://github.com/PhotonVision/photonvision synced 2026-06-25 01:41:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove % from ambiguity (#1017)

Browse Source 
* Remove % from ambiguity

* Update javadocs

---------

Co-authored-by: Sriman Achanta <68172138+srimanachanta@users.noreply.github.com>
This commit is contained in:
Matt
2023-11-25 14:06:22 -05:00
committed by GitHub
parent 3268e0d689
commit 16f63e4d90
3 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
photon-client/src/components/dashboard/tabs/TargetsTab.vue
View File

@@ -41,7 +41,7 @@ const currentPipelineSettings = useCameraSettingsStore().currentPipelineSettings
useCameraSettingsStore().currentPipelineSettings.solvePNPEnabled
"
>
<th class="text-center">Ambiguity %</th>
<th class="text-center">Ambiguity Ratio</th>
</template>
</tr>
</thead>
@@ -73,7 +73,7 @@ const currentPipelineSettings = useCameraSettingsStore().currentPipelineSettings
useCameraSettingsStore().currentPipelineSettings.solvePNPEnabled
"
>
<td>{{ target.ambiguity >= 0 ? target.ambiguity?.toFixed(2) + "%" : "(In Multi-Target)" }}</td>
<td>{{ target.ambiguity >= 0 ? target.ambiguity?.toFixed(2) : "(In Multi-Target)" }}</td>
</template>
</tr>
</tbody>

5
photon-targeting/src/main/java/org/photonvision/targeting/PhotonTrackedTarget.java
View File

@@ -97,8 +97,9 @@ public class PhotonTrackedTarget {
}
/**
* Get the ratio of pose reprojection errors, called ambiguity. Numbers above 0.2 are likely to be
* ambiguous. -1 if invalid.
* Get the ratio of best:alternate pose reprojection errors, called ambiguity. This is betweeen 0
* and 1 (0 being no ambiguity, and 1 meaning both have the same reprojection error). Numbers
* above 0.2 are likely to be ambiguous. -1 if invalid.
*/
public double getPoseAmbiguity() {
return poseAmbiguity;

6
photon-targeting/src/main/native/include/photon/targeting/PhotonTrackedTarget.h
View File

@@ -112,8 +112,10 @@ class PhotonTrackedTarget {
}
/**
* Get the ratio of pose reprojection errors, called ambiguity. Numbers above
* 0.2 are likely to be ambiguous. -1 if invalid.
* Get the ratio of best:alternate pose reprojection errors, called ambiguity.
* This is betweeen 0 and 1 (0 being no ambiguity, and 1 meaning both have the
* same reprojection error). Numbers above 0.2 are likely to be ambiguous. -1
* if invalid.
*/
double GetPoseAmbiguity() const { return poseAmbiguity; }