From 189da52a772f13fb42a8ec468722999a0a696b36 Mon Sep 17 00:00:00 2001 From: "Cameron (3539)" Date: Mon, 14 Oct 2024 20:15:08 -0400 Subject: [PATCH] Fix aruco draw (#1468) Someone hard-coded the 16h5 model. Additionally, the April tag pipeline redistorts the points before drawing them, so let's do that as well. --- .../org/photonvision/vision/pipe/impl/Draw3dArucoPipe.java | 1 + .../org/photonvision/vision/pipeline/OutputStreamPipeline.java | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/photon-core/src/main/java/org/photonvision/vision/pipe/impl/Draw3dArucoPipe.java b/photon-core/src/main/java/org/photonvision/vision/pipe/impl/Draw3dArucoPipe.java index 0fdd71935..9414f88b8 100644 --- a/photon-core/src/main/java/org/photonvision/vision/pipe/impl/Draw3dArucoPipe.java +++ b/photon-core/src/main/java/org/photonvision/vision/pipe/impl/Draw3dArucoPipe.java @@ -30,6 +30,7 @@ public class Draw3dArucoPipe extends Draw3dTargetsPipe { FrameDivisor divisor) { super(shouldDraw, cameraCalibrationCoefficients, targetModel, divisor); this.shouldDrawHull = false; + this.redistortPoints = true; } } } diff --git a/photon-core/src/main/java/org/photonvision/vision/pipeline/OutputStreamPipeline.java b/photon-core/src/main/java/org/photonvision/vision/pipeline/OutputStreamPipeline.java index b92735a53..efcb1096c 100644 --- a/photon-core/src/main/java/org/photonvision/vision/pipeline/OutputStreamPipeline.java +++ b/photon-core/src/main/java/org/photonvision/vision/pipeline/OutputStreamPipeline.java @@ -24,7 +24,6 @@ import org.photonvision.vision.frame.FrameStaticProperties; import org.photonvision.vision.opencv.DualOffsetValues; import org.photonvision.vision.pipe.impl.*; import org.photonvision.vision.pipeline.result.CVPipelineResult; -import org.photonvision.vision.target.TargetModel; import org.photonvision.vision.target.TrackedTarget; /** @@ -108,7 +107,7 @@ public class OutputStreamPipeline { new Draw3dArucoPipe.Draw3dArucoParams( settings.outputShouldDraw, frameStaticProperties.cameraCalibration, - TargetModel.kAprilTag6in_16h5, + settings.targetModel, settings.streamingFrameDivisor); draw3dArucoPipe.setParams(draw3dArucoParams);