From 27198a3e327ffebf4cd880515108cff4139c329c Mon Sep 17 00:00:00 2001 From: amquake Date: Fri, 21 Oct 2022 20:37:22 -0700 Subject: [PATCH] Don't spam log on client connection retry (#530) * dont spam log on connection retry * Move print into ntTick Update NetworkTablesManager.java Co-authored-by: Matt --- .../networktables/NetworkTablesManager.java | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/photon-core/src/main/java/org/photonvision/common/dataflow/networktables/NetworkTablesManager.java b/photon-core/src/main/java/org/photonvision/common/dataflow/networktables/NetworkTablesManager.java index 5efa9a388..0d7d6b57f 100644 --- a/photon-core/src/main/java/org/photonvision/common/dataflow/networktables/NetworkTablesManager.java +++ b/photon-core/src/main/java/org/photonvision/common/dataflow/networktables/NetworkTablesManager.java @@ -38,6 +38,8 @@ public class NetworkTablesManager { private final String kRootTableName = "/photonvision"; public final NetworkTable kRootTable = ntInstance.getTable(kRootTableName); + private boolean isRetryingConnection = false; + private NetworkTablesManager() { ntInstance.addLogger(new NTLogger(), 0, 255); // to hide error messages TimedTaskManager.getInstance().addTask("NTManager", this::ntTick, 5000); @@ -111,17 +113,11 @@ public class NetworkTablesManager { } private void setClientMode(int teamNumber) { - logger.info("Starting NT Client"); + if (!isRetryingConnection) logger.info("Starting NT Client"); ntInstance.stopServer(); ntInstance.startClientTeam(teamNumber); ntInstance.startDSClient(); - if (ntInstance.isConnected()) { - logger.info("[NetworkTablesManager] Connected to the robot!"); - } else { - logger.error( - "[NetworkTablesManager] Could not connect to the robot! Will retry in the background..."); - } broadcastVersion(); } @@ -142,5 +138,11 @@ public class NetworkTablesManager { && !ConfigManager.getInstance().getConfig().getNetworkConfig().runNTServer) { setConfig(ConfigManager.getInstance().getConfig().getNetworkConfig()); } + + if (!ntInstance.isConnected() && !isRetryingConnection) { + isRetryingConnection = true; + logger.error( + "[NetworkTablesManager] Could not connect to the robot! Will retry in the background..."); + } } }