Team2890/PhotonVision
4
0
Fork 0
mirror of https://github.com/PhotonVision/photonvision synced 2026-06-20 00:51:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix and unit test TimedTaskManager (#91)

Browse Source 
Adds TimedTaskManager unit test and switches back to standard executor instead of the custom subclass.
This commit is contained in:
Banks T
2020-08-17 16:24:15 -04:00
committed by GitHub
parent 832d8413e1
commit 38099e79cf
2 changed files with 35 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
photon-server/src/main/java/org/photonvision/common/util/TimedTaskManager.java
View File

@@ -48,40 +48,8 @@ public class TimedTaskManager {
}
}
private static class TimedTaskExecutorPool extends ScheduledThreadPoolExecutor {
public TimedTaskExecutorPool(int corePoolSize) {
super(corePoolSize, new CaughtThreadFactory());
}
// Thanks to Abdullah Ozturk for this tip
// https://medium.com/@aozturk/how-to-handle-uncaught-exceptions-in-java-abf819347906
@Override
protected void afterExecute(Runnable runnable, Throwable throwable) {
super.afterExecute(runnable, throwable);
// If submit() method is called instead of execute()
if (throwable == null && runnable instanceof Future<?>) {
try {
//noinspection unused
Object result = ((Future<?>) runnable).get();
} catch (CancellationException e) {
throwable = e;
} catch (ExecutionException e) {
throwable = e.getCause();
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
}
}
if (throwable != null) {
logger.error("TimedTask threw uncaught exception!", throwable);
// Restart the runnable again
execute(runnable);
}
}
}
private final ScheduledExecutorService timedTaskExecutorPool = new TimedTaskExecutorPool(2);
private final ScheduledExecutorService timedTaskExecutorPool =
new ScheduledThreadPoolExecutor(2, new CaughtThreadFactory());
private final ConcurrentHashMap<String, Future<?>> activeTasks = new ConcurrentHashMap<>();
public void addTask(String identifier, Runnable runnable, long millisInterval) {