Team2890/PhotonVision
4
0
Fork 0
mirror of https://github.com/PhotonVision/photonvision synced 2026-06-20 00:51:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use toList instead of collect(Collectors.toList()) when the list is definitely never modified

Browse Source
This commit is contained in:
Gold856
2025-03-27 08:17:07 -04:00
committed by Matt Morley
parent 23d5e5b34f
commit 38ee450117
18 changed files with 47 additions and 73 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
photon-lib/src/main/java/org/photonvision/PhotonCamera.java
View File

@@ -50,7 +50,6 @@ import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.Optional;
import java.util.stream.Collectors;
import org.opencv.core.Core;
import org.photonvision.common.hardware.VisionLEDMode;
import org.photonvision.common.networktables.PacketSubscriber;
@@ -594,6 +593,6 @@ public class PhotonCamera implements AutoCloseable {
it -> {
return rootPhotonTable.getSubTable(it).getEntry("rawBytes").exists();
})
.collect(Collectors.toList());
.toList();
}
}

6
photon-lib/src/main/java/org/photonvision/simulation/VisionSystemSim.java
View File

@@ -41,7 +41,6 @@ import java.util.List;
import java.util.Map;
import java.util.Optional;
import java.util.Set;
import java.util.stream.Collectors;
import org.photonvision.PhotonCamera;
import org.photonvision.estimation.TargetModel;
@@ -357,10 +356,7 @@ public class VisionSystemSim {
entry ->
dbgField
.getObject(entry.getKey())
.setPoses(
entry.getValue().stream()
.map(t -> t.getPose().toPose2d())
.collect(Collectors.toList())));
.setPoses(entry.getValue().stream().map(t -> t.getPose().toPose2d()).toList()));
if (robotPoseMeters == null) return;