Team2890/PhotonVision
4
0
Fork 0
mirror of https://github.com/PhotonVision/photonvision synced 2026-06-29 02:21:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Correctly stringify numbers in textboxes (#921)

Browse Source 
* fix an issue where the fov isnt reset on error

* Fix issue with incorrectly reading fov on update

* Properly handle NPE in case of error

* Fix issue with vuetify comps not converting strings to numbers

* Formatting fixes
This commit is contained in:
Sriman Achanta
2023-09-26 08:02:18 -04:00
committed by GitHub
parent 2cb87c5a88
commit 43eefcf1c5
4 changed files with 18 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
photon-client/src/components/cameras/CameraSettingsCard.vue
View File

@@ -3,20 +3,22 @@ import CvSelect from "@/components/common/cv-select.vue";
import CvNumberInput from "@/components/common/cv-number-input.vue";
import { useCameraSettingsStore } from "@/stores/settings/CameraSettingsStore";
import { useStateStore } from "@/stores/StateStore";
import { ref } from "vue";
import { ref, watchEffect } from "vue";
const currentFov = ref(useCameraSettingsStore().currentCameraSettings.fov.value);
const currentFov = ref();
const saveCameraSettings = () => {
useCameraSettingsStore()
.updateCameraSettings({ fov: currentFov.value }, true)
.updateCameraSettings({ fov: currentFov.value }, false)
.then((response) => {
useCameraSettingsStore().currentCameraSettings.fov.value = currentFov.value;
useStateStore().showSnackbarMessage({
color: "success",
message: response.data.text || response.data
});
})
.catch((error) => {
currentFov.value = useCameraSettingsStore().currentCameraSettings.fov.value;
if (error.response) {
useStateStore().showSnackbarMessage({
color: "error",
@@ -33,11 +35,12 @@ const saveCameraSettings = () => {
message: "An error occurred while trying to process the request."
});
}
})
.finally(() => {
useCameraSettingsStore().currentCameraSettings.fov.value = currentFov.value;
});
};
watchEffect(() => {
currentFov.value = useCameraSettingsStore().currentCameraSettings.fov.value;
});
</script>
<template>