Team2890/PhotonVision
4
0
Fork 0
mirror of https://github.com/PhotonVision/photonvision synced 2026-06-20 00:51:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Correctly stringify numbers in textboxes (#921)

Browse Source 
* fix an issue where the fov isnt reset on error

* Fix issue with incorrectly reading fov on update

* Properly handle NPE in case of error

* Fix issue with vuetify comps not converting strings to numbers

* Formatting fixes
This commit is contained in:
Sriman Achanta
2023-09-26 08:02:18 -04:00
committed by GitHub
parent 2cb87c5a88
commit 43eefcf1c5
4 changed files with 18 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
photon-server/src/main/java/org/photonvision/server/RequestHandler.java
View File

@@ -323,7 +323,7 @@ public class RequestHandler {
var data = kObjectMapper.readTree(ctx.body());
int index = data.get("index").asInt();
double fov = kObjectMapper.readTree(data.get("settings").asText()).get("fov").asDouble();
double fov = data.get("settings").get("fov").asDouble();
var module = VisionModuleManager.getInstance().getModule(index);
module.setFov(fov);
@@ -333,7 +333,7 @@ public class RequestHandler {
ctx.status(200);
ctx.result("Successfully saved camera settings");
logger.info("Successfully saved camera settings");
} catch (JsonProcessingException e) {
} catch (JsonProcessingException | NullPointerException e) {
ctx.status(400);
ctx.result("The provided camera settings were malformed");
logger.error("The provided camera settings were malformed", e);