Team2890/PhotonVision
4
0
Fork 0
mirror of https://github.com/PhotonVision/photonvision synced 2026-06-19 00:41:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update Sim Example Unit Conversions (#265)

Browse Source 
Updated Java examples to fix radians/degrees mismatch.

Inspected c++ examples - they create a units::degree_t from the NT value, which should be handled properly inside the PhotonUtils methods.
This commit is contained in:
Chris Gerth
2021-03-23 12:57:32 -05:00
committed by GitHub
parent 1e715ce4bb
commit 49fcdb64ed
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
photonlib-java-examples/src/main/java/org/photonlib/examples/aimandrange/Robot.java
View File

@@ -79,7 +79,7 @@ public class Robot extends TimedRobot {
CAMERA_HEIGHT_METERS,
TARGET_HEIGHT_METERS,
CAMERA_PITCH_RADIANS,
result.getBestTarget().getPitch());
Units.degreesToRadians(result.getBestTarget().getPitch()));
// Use this range as the measurement we give to the PID controller.
// -1.0 required to ensure positive PID controller effort _increases_ range

2
photonlib-java-examples/src/main/java/org/photonlib/examples/getinrange/Robot.java
View File

@@ -81,7 +81,7 @@ public class Robot extends TimedRobot {
CAMERA_HEIGHT_METERS,
TARGET_HEIGHT_METERS,
CAMERA_PITCH_RADIANS,
result.getBestTarget().getPitch());
Units.degreesToRadians(result.getBestTarget().getPitch()));
// Use this range as the measurement we give to the PID controller.
// -1.0 required to ensure positive PID controller effort _increases_ range