Team2890/PhotonVision
4
0
Fork 0
mirror of https://github.com/PhotonVision/photonvision synced 2026-06-22 01:11:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix typehint problem with ndarrays (#1631)

Browse Source 
mypy was inferring the wrong type for ndarrays in photonCameraSim.py.
This fixes the problem by adding typehints using numpy.typing.NDArray.
This commit is contained in:
Craig Schardt
2024-12-08 23:21:37 -06:00
committed by GitHub
parent 782929b006
commit 6a8d638853
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
photon-lib/py/photonlibpy/simulation/simCameraProperties.py
View File

@@ -4,6 +4,7 @@ import typing
import cv2 as cv
import numpy as np
import numpy.typing as npt
from wpimath.geometry import Rotation2d, Rotation3d, Translation3d
from wpimath.units import hertz, seconds
@@ -31,8 +32,8 @@ class SimCameraProperties:
"""Default constructor which is the same as {@link #PERFECT_90DEG}"""
self.resWidth: int = -1
self.resHeight: int = -1
self.camIntrinsics: np.ndarray = np.zeros((3, 3)) # [3,3]
self.distCoeffs: np.ndarray = np.zeros((8, 1)) # [8,1]
self.camIntrinsics: npt.NDArray[np.floating] = np.zeros((3, 3)) # [3,3]
self.distCoeffs: npt.NDArray[np.floating] = np.zeros((8, 1)) # [8,1]
self.avgErrorPx: float = 0.0
self.errorStdDevPx: float = 0.0
self.frameSpeed: seconds = 0.0
@@ -172,10 +173,10 @@ class SimCameraProperties:
def getAspectRatio(self) -> float:
return 1.0 * self.resWidth / self.resHeight
def getIntrinsics(self) -> np.ndarray:
def getIntrinsics(self) -> npt.NDArray[np.floating]:
return self.camIntrinsics
def getDistCoeffs(self) -> np.ndarray:
def getDistCoeffs(self) -> npt.NDArray[np.floating]:
return self.distCoeffs
def getFPS(self) -> hertz: