Team2890/PhotonVision
4
0
Fork 0
mirror of https://github.com/PhotonVision/photonvision synced 2026-06-21 01:01:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Logging additions 2 (#55)

Browse Source 
* Add overload to logger.error() for Throwable to print stack trace

* Replaced all e.printStackTrace() with logger.error()

* Log level dependent on dev or release
This commit is contained in:
Banks T
2020-07-24 12:06:54 -04:00
committed by GitHub
parent 22d7ccc74d
commit 77fd6a84c8
17 changed files with 74 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
photon-server/src/main/java/org/photonvision/common/scripting/ScriptEvent.java
View File

@@ -39,7 +39,7 @@ public class ScriptEvent {
String error = executor.getError();
if (!error.isEmpty()) {
System.err.printf("Error when running \"%s\" script: %s\n", config.eventType.name(), error);
logger.error("Error when running \"" + config.eventType.name() + "\" script: " + error);
} else if (!output.isEmpty()) {
logger.info(
String.format("Output from \"%s\" script: %s\n", config.eventType.name(), output));

14
photon-server/src/main/java/org/photonvision/common/scripting/ScriptManager.java
View File

@@ -51,7 +51,7 @@ public class ScriptManager {
TimedTaskManager.getInstance().addTask("ScriptRunner", new ScriptRunner(), 10);
} else {
System.err.println("Something went wrong initializing scripts! Events will not run.");
logger.error("Something went wrong initializing scripts! Events will not run.");
}
}
@@ -61,7 +61,7 @@ public class ScriptManager {
try {
handleEvent(queuedEvents.takeFirst());
} catch (InterruptedException e) {
e.printStackTrace();
logger.error("ScriptRunner queue interrupted!", e);
}
}
@@ -76,9 +76,7 @@ public class ScriptManager {
try {
toRun.run();
} catch (IOException e) {
System.err.printf(
"Failed to run script for event: %s, exception below.\n%s\n",
eventType.name(), e.getMessage());
logger.error("Failed to run script for event \"" + eventType.name() + "\"", e);
}
}
}
@@ -107,7 +105,7 @@ public class ScriptManager {
JacksonUtils.serializer(
scriptConfigPath, eventsConfig.toArray(new ScriptConfig[0]), true);
} catch (IOException e) {
e.printStackTrace();
logger.error("Failed to initialize!", e);
}
}
}
@@ -119,7 +117,7 @@ public class ScriptManager {
return List.of(raw);
}
} catch (IOException e) {
e.printStackTrace();
logger.error("Failed to load scripting config!", e);
}
return new ArrayList<>();
}
@@ -139,7 +137,7 @@ public class ScriptManager {
queuedEvents.putLast(eventType);
logger.info("Queued event: " + eventType.name());
} catch (InterruptedException e) {
System.err.println("Failed to add event to queue: " + eventType.name());
logger.error("Failed to add event to queue: " + eventType.name(), e);
}
}
}