From 78f57600ccc06ec9dc5698d6ee47be241d1f8400 Mon Sep 17 00:00:00 2001
From: Gold856 <117957790+Gold856@users.noreply.github.com>
Date: Wed, 9 Jul 2025 00:40:21 -0400
Subject: [PATCH] Set a more sane timeout for WS connections and log WS errors
 (#1992)

---
 .../main/java/org/photonvision/server/DataSocketHandler.java   | 3 +--
 .../src/main/java/org/photonvision/server/Server.java          | 1 +
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/photon-server/src/main/java/org/photonvision/server/DataSocketHandler.java b/photon-server/src/main/java/org/photonvision/server/DataSocketHandler.java
index 848c7a447..69bbd92fe 100644
--- a/photon-server/src/main/java/org/photonvision/server/DataSocketHandler.java
+++ b/photon-server/src/main/java/org/photonvision/server/DataSocketHandler.java
@@ -69,8 +69,7 @@ public class DataSocketHandler {
 
     public void onConnect(WsConnectContext context) {
         users.add(context);
-        context.session.setIdleTimeout(
-                Duration.ofMillis(Long.MAX_VALUE)); // TODO: determine better value
+        context.session.setIdleTimeout(Duration.ofMillis(5000));
         var remote = (InetSocketAddress) context.session.getRemoteAddress();
         var host = remote.getAddress().toString() + ":" + remote.getPort();
         logger.info("New websocket connection from " + host);
diff --git a/photon-server/src/main/java/org/photonvision/server/Server.java b/photon-server/src/main/java/org/photonvision/server/Server.java
index c50fab873..b202b8507 100644
--- a/photon-server/src/main/java/org/photonvision/server/Server.java
+++ b/photon-server/src/main/java/org/photonvision/server/Server.java
@@ -109,6 +109,7 @@ public class Server {
                 ws -> {
                     ws.onConnect(dsHandler::onConnect);
                     ws.onClose(dsHandler::onClose);
+                    ws.onError(e -> logger.error(e.toString(), e.error()));
                     ws.onBinaryMessage(dsHandler::onBinaryMessage);
                 });