From 81d19672d22707d31eb952118c1a5702f27792ed Mon Sep 17 00:00:00 2001 From: Jack <31329139+realSaddy@users.noreply.github.com> Date: Fri, 28 Oct 2022 17:54:57 -0500 Subject: [PATCH] Change order of drawing to better show axes (#541) --- .../vision/pipe/impl/Draw3dTargetsPipe.java | 45 ++++++++++--------- 1 file changed, 23 insertions(+), 22 deletions(-) diff --git a/photon-core/src/main/java/org/photonvision/vision/pipe/impl/Draw3dTargetsPipe.java b/photon-core/src/main/java/org/photonvision/vision/pipe/impl/Draw3dTargetsPipe.java index 6fca49d19..e0be18d75 100644 --- a/photon-core/src/main/java/org/photonvision/vision/pipe/impl/Draw3dTargetsPipe.java +++ b/photon-core/src/main/java/org/photonvision/vision/pipe/impl/Draw3dTargetsPipe.java @@ -118,22 +118,6 @@ public class Draw3dTargetsPipe ColorHelper.colorToScalar(Color.green), 3); } - for (int i = 0; i < bottomPoints.size(); i++) { - Imgproc.line( - in.getLeft(), - bottomPoints.get(i), - topPoints.get(i), - ColorHelper.colorToScalar(Color.blue), - 3); - } - for (int i = 0; i < topPoints.size(); i++) { - Imgproc.line( - in.getLeft(), - topPoints.get(i), - topPoints.get((i + 1) % (bottomPoints.size())), - ColorHelper.colorToScalar(Color.orange), - 3); - } // Draw X, Y and Z axis MatOfPoint3f pointMat = new MatOfPoint3f(); @@ -163,12 +147,6 @@ public class Draw3dTargetsPipe dividePointList(axisPoints); // Red = x, green y, blue z - Imgproc.line( - in.getLeft(), - axisPoints.get(0), - axisPoints.get(1), - ColorHelper.colorToScalar(Color.RED), - 3); Imgproc.line( in.getLeft(), axisPoints.get(0), @@ -181,6 +159,29 @@ public class Draw3dTargetsPipe axisPoints.get(3), ColorHelper.colorToScalar(Color.BLUE), 3); + Imgproc.line( + in.getLeft(), + axisPoints.get(0), + axisPoints.get(1), + ColorHelper.colorToScalar(Color.RED), + 3); + + for (int i = 0; i < bottomPoints.size(); i++) { + Imgproc.line( + in.getLeft(), + bottomPoints.get(i), + topPoints.get(i), + ColorHelper.colorToScalar(Color.blue), + 3); + } + for (int i = 0; i < topPoints.size(); i++) { + Imgproc.line( + in.getLeft(), + topPoints.get(i), + topPoints.get((i + 1) % (bottomPoints.size())), + ColorHelper.colorToScalar(Color.orange), + 3); + } tempMat.release(); jac.release();