From ab844a77b8080398088b81cccc7753f3efb14c51 Mon Sep 17 00:00:00 2001 From: "Cameron (3539)" Date: Fri, 3 Jan 2025 18:50:25 -0500 Subject: [PATCH] Remove camera index in ui (#1677) With the new camera matching, this is SUPER BAD! Convert to using camera uuid. --------- Co-authored-by: Matt --- photon-client/src/App.vue | 4 +- .../src/components/app/photon-sidebar.vue | 3 +- .../components/cameras/CameraSettingsCard.vue | 18 +- .../src/components/common/pv-select.vue | 6 +- .../dashboard/CameraAndPipelineSelectCard.vue | 24 +- photon-client/src/stores/StateStore.ts | 13 +- .../stores/settings/CameraSettingsStore.ts | 265 +++++++++--------- photon-client/src/types/WebsocketDataTypes.ts | 2 +- .../src/views/CameraMatchingView.vue | 25 +- photon-client/src/views/DashboardView.vue | 5 +- .../events/IncomingWebSocketEvent.java | 10 +- .../statusLEDs/StatusLEDConsumer.java | 8 +- .../dataflow/websocket/UIDataPublisher.java | 10 +- .../common/hardware/HardwareManager.java | 6 +- .../vision/processes/VisionModule.java | 11 +- .../VisionModuleChangeSubscriber.java | 4 +- .../vision/processes/VisionModuleManager.java | 12 +- .../server/DataSocketHandler.java | 40 +-- .../photonvision/server/RequestHandler.java | 55 ++-- 19 files changed, 271 insertions(+), 250 deletions(-) diff --git a/photon-client/src/App.vue b/photon-client/src/App.vue index 6c97112c4..0d24fbed5 100644 --- a/photon-client/src/App.vue +++ b/photon-client/src/App.vue @@ -34,8 +34,8 @@ if (!is_demo) { if (data.updatePipelineResult !== undefined) { useStateStore().updateBackendResultsFromWebsocket(data.updatePipelineResult); } - if (data.mutatePipelineSettings !== undefined && data.cameraIndex !== undefined) { - useCameraSettingsStore().changePipelineSettingsInStore(data.mutatePipelineSettings, data.cameraIndex); + if (data.mutatePipelineSettings !== undefined && data.cameraUniqueName !== undefined) { + useCameraSettingsStore().changePipelineSettingsInStore(data.mutatePipelineSettings, data.cameraUniqueName); } if (data.calibrationData !== undefined) { useStateStore().updateCalibrationStateValuesFromWebsocket(data.calibrationData); diff --git a/photon-client/src/components/app/photon-sidebar.vue b/photon-client/src/components/app/photon-sidebar.vue index 7d62195c3..776c09927 100644 --- a/photon-client/src/components/app/photon-sidebar.vue +++ b/photon-client/src/components/app/photon-sidebar.vue @@ -20,7 +20,8 @@ const mdAndUp = computed(() => getCurrentInstance()?.proxy.$vuetify.bre const needsCamerasConfigured = computed(() => { return ( - useCameraSettingsStore().cameras.length === 0 || useCameraSettingsStore().cameras[0] === PlaceholderCameraSettings + Object.values(useCameraSettingsStore().cameras).length === 0 || + useCameraSettingsStore().cameras["PlaceHolder Name"] === PlaceholderCameraSettings ); }); diff --git a/photon-client/src/components/cameras/CameraSettingsCard.vue b/photon-client/src/components/cameras/CameraSettingsCard.vue index 5d72dc92a..9539fc7cc 100644 --- a/photon-client/src/components/cameras/CameraSettingsCard.vue +++ b/photon-client/src/components/cameras/CameraSettingsCard.vue @@ -1,5 +1,5 @@