Team2890/PhotonVision
4
0
Fork 0
mirror of https://github.com/PhotonVision/photonvision synced 2026-06-19 00:41:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Stop type hinting members as optional in PhotonTrackedTarget (#1539)

Browse Source 
List types should never be optional if sent to NT because an empty list conveys the same
thing.

The equivalent C++ struct takes the same approach with empty vectors rather than an optional vector.
This commit is contained in:
Lucien Morey
2024-11-09 10:58:56 +11:00
committed by GitHub
parent 4cf1c7eee4
commit bdb2949b4b
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
photon-lib/py/photonlibpy/targeting/photonTrackedTarget.py
View File

@@ -13,8 +13,8 @@ class PhotonTrackedTarget:
fiducialId: int = -1
bestCameraToTarget: Transform3d = field(default_factory=Transform3d)
altCameraToTarget: Transform3d = field(default_factory=Transform3d)
minAreaRectCorners: list[TargetCorner] | None = None
detectedCorners: list[TargetCorner] | None = None
minAreaRectCorners: list[TargetCorner] = field(default_factory=list[TargetCorner])
detectedCorners: list[TargetCorner] = field(default_factory=list[TargetCorner])
poseAmbiguity: float = 0.0
def getYaw(self) -> float:
@@ -35,10 +35,10 @@ class PhotonTrackedTarget:
def getPoseAmbiguity(self) -> float:
return self.poseAmbiguity
def getMinAreaRectCorners(self) -> list[TargetCorner] | None:
def getMinAreaRectCorners(self) -> list[TargetCorner]:
return self.minAreaRectCorners
def getDetectedCorners(self) -> list[TargetCorner] | None:
def getDetectedCorners(self) -> list[TargetCorner]:
return self.detectedCorners
def getBestCameraToTarget(self) -> Transform3d: