From bdb2949b4b92a28ad3c841ec4ae5875f6a95ea03 Mon Sep 17 00:00:00 2001 From: Lucien Morey Date: Sat, 9 Nov 2024 10:58:56 +1100 Subject: [PATCH] Stop type hinting members as optional in PhotonTrackedTarget (#1539) List types should never be optional if sent to NT because an empty list conveys the same thing. The equivalent C++ struct takes the same approach with empty vectors rather than an optional vector. --- .../py/photonlibpy/targeting/photonTrackedTarget.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/photon-lib/py/photonlibpy/targeting/photonTrackedTarget.py b/photon-lib/py/photonlibpy/targeting/photonTrackedTarget.py index b9204c829..7cd729699 100644 --- a/photon-lib/py/photonlibpy/targeting/photonTrackedTarget.py +++ b/photon-lib/py/photonlibpy/targeting/photonTrackedTarget.py @@ -13,8 +13,8 @@ class PhotonTrackedTarget: fiducialId: int = -1 bestCameraToTarget: Transform3d = field(default_factory=Transform3d) altCameraToTarget: Transform3d = field(default_factory=Transform3d) - minAreaRectCorners: list[TargetCorner] | None = None - detectedCorners: list[TargetCorner] | None = None + minAreaRectCorners: list[TargetCorner] = field(default_factory=list[TargetCorner]) + detectedCorners: list[TargetCorner] = field(default_factory=list[TargetCorner]) poseAmbiguity: float = 0.0 def getYaw(self) -> float: @@ -35,10 +35,10 @@ class PhotonTrackedTarget: def getPoseAmbiguity(self) -> float: return self.poseAmbiguity - def getMinAreaRectCorners(self) -> list[TargetCorner] | None: + def getMinAreaRectCorners(self) -> list[TargetCorner]: return self.minAreaRectCorners - def getDetectedCorners(self) -> list[TargetCorner] | None: + def getDetectedCorners(self) -> list[TargetCorner]: return self.detectedCorners def getBestCameraToTarget(self) -> Transform3d: