From d188c37466d14bfa2a6408b359b31b1279bb3b23 Mon Sep 17 00:00:00 2001 From: Lucien Morey Date: Sun, 10 Nov 2024 09:32:35 +1100 Subject: [PATCH] Fix missing vars and catch bad shim (#1541) I made a mistake when cherry-picking things into #1534. Fixing it also prompted me to regenerate message things without thinking even though it wasn't needed here but it helped me catch an issue with a bad shim. I must not have saved it properly on my computer and missed it before review. --- photon-lib/py/photonlibpy/targeting/photonTrackedTarget.py | 2 ++ photon-serde/message_data_types.yaml | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/photon-lib/py/photonlibpy/targeting/photonTrackedTarget.py b/photon-lib/py/photonlibpy/targeting/photonTrackedTarget.py index 7cd729699..d89482f62 100644 --- a/photon-lib/py/photonlibpy/targeting/photonTrackedTarget.py +++ b/photon-lib/py/photonlibpy/targeting/photonTrackedTarget.py @@ -16,6 +16,8 @@ class PhotonTrackedTarget: minAreaRectCorners: list[TargetCorner] = field(default_factory=list[TargetCorner]) detectedCorners: list[TargetCorner] = field(default_factory=list[TargetCorner]) poseAmbiguity: float = 0.0 + objDetectId: int = -1 + objDetectConf: float = 0.0 def getYaw(self) -> float: return self.yaw diff --git a/photon-serde/message_data_types.yaml b/photon-serde/message_data_types.yaml index 85fdc608b..7970dd80a 100644 --- a/photon-serde/message_data_types.yaml +++ b/photon-serde/message_data_types.yaml @@ -18,7 +18,7 @@ int32: java_type: int cpp_type: int32_t java_decode_method: decodeInt - java_encode_shim: encodeBoolean + java_encode_shim: encodeInt int64: len: 8 java_type: long