Team2890/PhotonVision
4
0
Fork 0
mirror of https://github.com/PhotonVision/photonvision synced 2026-06-27 02:01:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Disallow low-resolution calibration (#2438)

Browse Source
This commit is contained in:
Charlotte Wilson
2026-05-03 14:00:11 -04:00
committed by GitHub
parent c195d7ccc0
commit dbf71029b7
2 changed files with 20 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
photon-client/src/components/cameras/CameraCalibrationCard.vue
View File

@@ -38,6 +38,11 @@ const getUniqueVideoFormatsByResolution = (): VideoFormat[] => {
if (!skip) {
const calib = useCameraSettingsStore().getCalibrationCoeffs(format.resolution);
// minPixelCount is the multiplied area of a 640x480 (the minimum for proper calibration) resolution
const minPixelCount = 640 * 480;
const resArea = format.resolution.width * format.resolution.height;
if (calib !== undefined) {
// Mean overall reprojection error
// Calculated as average of each observation's mean error
@@ -60,7 +65,10 @@ const getUniqueVideoFormatsByResolution = (): VideoFormat[] => {
) *
(180 / Math.PI);
}
uniqueResolutions.push(format);
if (resArea >= minPixelCount) {
uniqueResolutions.push(format);
}
}
});
uniqueResolutions.sort(
@@ -86,12 +94,19 @@ const uniqueVideoResolutionString = ref("");
// Use a watchEffect so the value is populated/reacts when the stores become available or update.
// This avoids trying to index into an array that may be empty during page reload.
watchEffect(() => {
const currentIndex = useCameraSettingsStore().currentVideoFormat.index ?? 0;
useStateStore().calibrationData.videoFormatIndex = currentIndex;
const names = useCameraSettingsStore().currentCameraSettings.validVideoFormats.map((f) =>
getResolutionString(f.resolution)
);
uniqueVideoResolutionString.value = names[currentIndex] ?? names[0] ?? "";
const currentFormatIndex = useCameraSettingsStore().currentVideoFormat.index ?? 0;
// Checks if the current resolution is present in the list of valid formats, if not defaults to the last index (which is usually the highest resolution)
const currentIndex =
getUniqueVideoResolutionStrings()
.map((x) => x.name)
.find((n) => n === names[currentFormatIndex]) !== undefined
? currentFormatIndex
: names.length - 1;
useStateStore().calibrationData.videoFormatIndex = currentIndex;
uniqueVideoResolutionString.value = names[currentIndex] ?? "";
});
const squareSizeIn = ref(1);
const markerSizeIn = ref(0.75);