Team2890/PhotonVision
4
0
Fork 0
mirror of https://github.com/PhotonVision/photonvision synced 2026-06-20 00:51:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use Math.hypot instead of Math.sqrt(a^2 + b^2)

Browse Source
This commit is contained in:
Gold856
2025-03-30 01:30:43 -04:00
committed by Matt Morley
parent 38ee450117
commit e514071094
5 changed files with 7 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
photon-lib/src/main/java/org/photonvision/simulation/SimCameraProperties.java
View File

@@ -171,7 +171,7 @@ public class SimCameraProperties {
DriverStation.reportError(
"Requested invalid FOV! Clamping between (1, 179) degrees...", false);
}
double resDiag = Math.sqrt(resWidth * resWidth + resHeight * resHeight);
double resDiag = Math.hypot(resWidth, resHeight);
double diagRatio = Math.tan(fovDiag.getRadians() / 2);
var fovWidth = new Rotation2d(Math.atan(diagRatio * (resWidth / resDiag)) * 2);
var fovHeight = new Rotation2d(Math.atan(diagRatio * (resHeight / resDiag)) * 2);