Team2890/PhotonVision
4
0
Fork 0
mirror of https://github.com/PhotonVision/photonvision synced 2026-07-02 02:51:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Clarify and fix OpenCV/WPILib version checking error (#1963)

Browse Source 
## Description

Fixed the error in the OpenCV/WPILib version checking crash and
clarified it, since it's not PhotonVision that needs updating, but
rather WPILib.

Reported on chief
https://www.chiefdelphi.com/t/opencv-is-version-4-6-0-and-needs-to-be-4-10-0/501751/7

## Meta

Merge checklist:
- [x] Pull Request title is [short, imperative
summary](https://cbea.ms/git-commit/) of proposed changes
- [x] The description documents the _what_ and _why_
- [ ] If this PR changes behavior or adds a feature, user documentation
is updated
- [ ] If this PR touches photon-serde, all messages have been
regenerated and hashes have not changed unexpectedly
- [ ] If this PR touches configuration, this is backwards compatible
with settings back to v2024.3.1
- [ ] If this PR touches pipeline settings or anything related to data
exchange, the frontend typing is updated
- [ ] If this PR addresses a bug, a regression test for it is added

---------

Signed-off-by: Jade Turner <spacey-sooty@proton.me>
Co-authored-by: Gold856 <117957790+Gold856@users.noreply.github.com>
This commit is contained in:
Jade
2025-07-12 17:44:55 +08:00
committed by GitHub
parent 7f6edcd567
commit ef5e6463cb
2 changed files with 42 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
photon-lib/src/main/java/org/photonvision/PhotonCamera.java
View File

@@ -195,11 +195,18 @@ public class PhotonCamera implements AutoCloseable {
+ ">>> but you are using WPILib " + ">>> but you are using WPILib "
+ WPILibVersion.Version + WPILibVersion.Version
+ """ + """
>>> \s \n>>> \s
>>> This is neither tested nor supported. \s >>> This is neither tested nor supported. \s
>>> You MUST update PhotonVision, \s >>> You MUST update WPILib, PhotonLib, or both.
>>> PhotonLib, or both. \s >>> Check `./gradlew dependencies` and ensure\s
>>> Verify the output of `./gradlew dependencies` >>> all mentions of OpenCV match the version \s
>>> that PhotonLib was built for. If you find a
>>> a mismatched version in a dependency, you\s
>>> must take steps to update the version of \s
>>> OpenCV used in that dependency. If you do\s
>>> not control that dependency and an updated\s
>>> version is not available, contact the \s
>>> developers of that dependency. \s
>>> \s >>> \s
>>> Your code will now crash. \s >>> Your code will now crash. \s
>>> We hope your day gets better. \s >>> We hope your day gets better. \s
@@ -232,11 +239,18 @@ public class PhotonCamera implements AutoCloseable {
+ ">>> but you are using OpenCV " + ">>> but you are using OpenCV "
+ Core.VERSION + Core.VERSION
+ """ + """
>>> \s \n>>> \s
>>> This is neither tested nor supported. \s >>> This is neither tested nor supported. \s
>>> You MUST update PhotonVision, \s >>> You MUST update WPILib, PhotonLib, or both.
>>> PhotonLib, or both. \s >>> Check `./gradlew dependencies` and ensure\s
>>> Verify the output of `./gradlew dependencies` >>> all mentions of OpenCV match the version \s
>>> that PhotonLib was built for. If you find a
>>> a mismatched version in a dependency, you\s
>>> must take steps to update the version of \s
>>> OpenCV used in that dependency. If you do\s
>>> not control that dependency and an updated\s
>>> version is not available, contact the \s
>>> developers of that dependency. \s
>>> \s >>> \s
>>> Your code will now crash. \s >>> Your code will now crash. \s
>>> We hope your day gets better. \s >>> We hope your day gets better. \s

26
photon-lib/src/main/native/cpp/photon/PhotonCamera.cpp
View File

@@ -69,9 +69,16 @@ inline void verifyDependencies() {
bfw += bfw +=
"\n>>> \n" "\n>>> \n"
">>> This is neither tested nor supported. \n" ">>> This is neither tested nor supported. \n"
">>> You MUST update PhotonVision, \n" ">>> You MUST update WPILib, PhotonLib, or both.\n"
">>> PhotonLib, or both. \n" ">>> Check `./gradlew dependencies` and ensure\n"
">>> Verify the output of `./gradlew dependencies` \n" ">>> all mentions of WPILib match the version \n"
">>> that PhotonLib was built for. If you find a"
">>> a mismatched version in a dependency, you\n"
">>> must take steps to update the version of \n"
">>> WPILib used in that dependency. If you do\n"
">>> not control that dependency and an updated\n"
">>> version is not available, contact the \n"
">>> developers of that dependency. \n"
">>> \n" ">>> \n"
">>> Your code will now crash. \n" ">>> Your code will now crash. \n"
">>> We hope your day gets better. \n" ">>> We hope your day gets better. \n"
@@ -104,9 +111,16 @@ inline void verifyDependencies() {
bfw += bfw +=
"\n>>> \n" "\n>>> \n"
">>> This is neither tested nor supported. \n" ">>> This is neither tested nor supported. \n"
">>> You MUST update PhotonVision, \n" ">>> You MUST update WPILib, PhotonLib, or both.\n"
">>> PhotonLib, or both. \n" ">>> Check `./gradlew dependencies` and ensure\n"
">>> Verify the output of `./gradlew dependencies` \n" ">>> all mentions of OpenCV match the version \n"
">>> that PhotonLib was built for. If you find a"
">>> a mismatched version in a dependency, you\n"
">>> must take steps to update the version of \n"
">>> OpenCV used in that dependency. If you do\n"
">>> not control that dependency and an updated\n"
">>> version is not available, contact the \n"
">>> developers of that dependency. \n"
">>> \n" ">>> \n"
">>> Your code will now crash. \n" ">>> Your code will now crash. \n"
">>> We hope your day gets better. \n" ">>> We hope your day gets better. \n"