[PhotonClient] Fix misc bugs and dataflow errors (#861)

Fixes leftover bugs from #767 and #856

- Because new URLs aren't based on hash URL schemas, all the routes need to be updated to final paths instead of relative ones that were previously caught by the hash URL
- Fixed misc Vue warnings pointed out by @mcm001
This commit is contained in:
Sriman Achanta
2023-06-18 00:05:46 -04:00
committed by GitHub
parent 013ff5e7c0
commit f813048462
6 changed files with 15 additions and 18 deletions

View File

@@ -144,7 +144,7 @@
</v-menu>
</v-col>
<v-col
v-if="currentPipelineType >= 0"
v-if="_currentPipelineType >= 0"
cols="10"
md="11"
lg="10"
@@ -152,7 +152,7 @@
class="pa-0"
>
<CVselect
v-model="currentPipelineType"
v-model="_currentPipelineType"
name="Type"
tooltip="Changes the pipeline type, which changes the type of processing that will happen on input frames"
:list="['Reflective Tape', 'Colored Shape', 'AprilTag']"
@@ -321,7 +321,7 @@ export default {
this.$store.commit('currentPipelineIndex', value - (this.$store.getters.isDriverMode ? 1 : 0));
}
},
currentPipelineType: {
_currentPipelineType: {
get() {
return this.$store.getters.currentPipelineSettings.pipelineType - 2;
},
@@ -333,11 +333,11 @@ export default {
methods: {
showTypeDialog(idx) {
// Only show the dialog if it's a new type
this.showPipeTypeDialog = idx !== this.currentPipelineType;
this.showPipeTypeDialog = idx !== this._currentPipelineType;
this.proposedPipelineType = idx;
},
changePipeType(actuallyChange) {
const newIdx = actuallyChange ? this.proposedPipelineType : this.currentPipelineType
const newIdx = actuallyChange ? this.proposedPipelineType : this._currentPipelineType
this.handleInputWithIndex('pipelineType', newIdx);
this.showPipeTypeDialog = false;
},
@@ -387,7 +387,7 @@ export default {
if (this.isPipelineNameEdit) {
this.handleInputWithIndex("changePipelineName", this.newPipelineName);
} else {
this.handleInputWithIndex("addNewPipeline", [this.newPipelineName, this.currentPipelineType]); // 0 for reflective, 1 for colored shape
this.handleInputWithIndex("addNewPipeline", [this.newPipelineName, this._currentPipelineType]); // 0 for reflective, 1 for colored shape
}
this.discardPipelineNameChange();
}