From f922466d4143ca67d97aa87c5454b119ccd2ee38 Mon Sep 17 00:00:00 2001 From: Matt Date: Tue, 5 Oct 2021 12:16:50 -0400 Subject: [PATCH] Fix contour grouping (#298) Fixes bug where n+1 contours were needed to match a target of size n --- .../org/photonvision/vision/pipe/impl/GroupContoursPipe.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/photon-core/src/main/java/org/photonvision/vision/pipe/impl/GroupContoursPipe.java b/photon-core/src/main/java/org/photonvision/vision/pipe/impl/GroupContoursPipe.java index e52201544..258a11afa 100644 --- a/photon-core/src/main/java/org/photonvision/vision/pipe/impl/GroupContoursPipe.java +++ b/photon-core/src/main/java/org/photonvision/vision/pipe/impl/GroupContoursPipe.java @@ -46,7 +46,7 @@ public class GroupContoursPipe } else { int groupingCount = params.getGroup().count; - if (input.size() > groupingCount) { + if (input.size() >= groupingCount) { input.sort(Contour.SortByMomentsX); // also why reverse? shouldn't the sort comparator just get reversed? // TODO: Matt, see this