mirror of
https://github.com/PhotonVision/photonvision
synced 2026-06-19 00:41:41 +00:00
d44d9fbbeb
## Description #1900 updated how the value was handled in pv-slider, and unintentionally removed bounds protection. This restores bounds protection. Unfortunately, there is an edge case that might be rather difficult to solve. If the slider is already at the min/max, you can enter a number through the text field, and while the value won't actually update, the text field keeps the entered value, likely because the model value didn't change, and therefore, a rerender isn't triggered. However, this is an edge case that I doubt many people will actually encounter, so we should still ship this. Fixes #2221. ## Meta Merge checklist: - [x] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes - [x] The description documents the _what_ and _why_ - [ ] If this PR changes behavior or adds a feature, user documentation is updated - [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly - [ ] If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2 - [ ] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated - [x] If this PR addresses a bug, a regression test for it is added
40 lines
1.9 KiB
TypeScript
40 lines
1.9 KiB
TypeScript
import { expect } from "@playwright/test";
|
|
import { test } from "./fixtures.ts";
|
|
|
|
test("Camera Gain Slider won't go past max or min", async ({ page }) => {
|
|
await page.goto("http://localhost:5800/#/dashboard");
|
|
await page.locator("div").filter({ hasText: "Set up some cameras to get started!" }).nth(2).press("Escape");
|
|
|
|
// Fill in Camera Gain text field with 1000
|
|
await page.locator("#input-v-44").fill("1000");
|
|
await page.locator("#input-v-44").press("Enter");
|
|
await expect(page.locator("#input-v-44")).toHaveValue("100");
|
|
|
|
// Try using buttons to go past the max
|
|
await page.getByRole("button", { name: "appended action" }).nth(2).click();
|
|
await expect(page.locator("#input-v-44")).toHaveValue("100");
|
|
|
|
// Make sure the value is actually properly limited, not just visually
|
|
await page.getByRole("button", { name: "prepended action" }).nth(2).click();
|
|
await expect(page.locator("#input-v-44")).toHaveValue("99");
|
|
|
|
await page.locator("#input-v-44").fill("-10");
|
|
await page.locator("#input-v-44").press("Enter");
|
|
await expect(page.locator("#input-v-44")).toHaveValue("0");
|
|
|
|
await page.getByRole("button", { name: "prepended action" }).nth(2).click();
|
|
await expect(page.locator("#input-v-44")).toHaveValue("0");
|
|
|
|
// Make sure the value is actually properly limited, not just visually
|
|
await page.getByRole("button", { name: "appended action" }).nth(2).click();
|
|
await expect(page.locator("#input-v-44")).toHaveValue("1");
|
|
|
|
// Make sure that the guard actually prevents value setting, instead of just reverting the value
|
|
// This can be ensured by making sure the Camera Gain field doesn't disappear (disappears when the value is -1)
|
|
await page.getByRole("button", { name: "prepended action" }).nth(2).click();
|
|
await page.getByRole("button", { name: "prepended action" }).nth(2).click();
|
|
await expect(page.locator("#input-v-44")).toHaveValue("0");
|
|
|
|
await expect(page.getByText("Camera Gain", { exact: true })).toBeVisible();
|
|
});
|