2013-12-15 18:30:16 -05:00
|
|
|
/*----------------------------------------------------------------------------*/
|
2016-01-02 03:02:34 -08:00
|
|
|
/* Copyright (c) FIRST 2011-2016. All Rights Reserved. */
|
2013-12-15 18:30:16 -05:00
|
|
|
/* Open Source Software - may be modified and shared by FRC teams. The code */
|
2016-01-02 03:02:34 -08:00
|
|
|
/* must be accompanied by the FIRST BSD license file in the root directory of */
|
|
|
|
|
/* the project. */
|
2013-12-15 18:30:16 -05:00
|
|
|
/*----------------------------------------------------------------------------*/
|
|
|
|
|
|
|
|
|
|
#include "Commands/PIDSubsystem.h"
|
2016-09-25 16:50:13 -07:00
|
|
|
|
2013-12-15 18:30:16 -05:00
|
|
|
#include "PIDController.h"
|
|
|
|
|
|
2016-11-01 22:33:12 -07:00
|
|
|
using namespace frc;
|
|
|
|
|
|
2013-12-15 18:30:16 -05:00
|
|
|
/**
|
2015-06-25 15:07:55 -04:00
|
|
|
* Instantiates a {@link PIDSubsystem} that will use the given p, i and d
|
|
|
|
|
* values.
|
2016-05-20 17:30:37 -07:00
|
|
|
*
|
2013-12-15 18:30:16 -05:00
|
|
|
* @param name the name
|
2016-05-20 17:30:37 -07:00
|
|
|
* @param p the proportional value
|
|
|
|
|
* @param i the integral value
|
|
|
|
|
* @param d the derivative value
|
2013-12-15 18:30:16 -05:00
|
|
|
*/
|
2016-05-20 17:30:37 -07:00
|
|
|
PIDSubsystem::PIDSubsystem(const std::string& name, double p, double i,
|
|
|
|
|
double d)
|
2015-06-25 15:07:55 -04:00
|
|
|
: Subsystem(name) {
|
2015-07-24 19:19:40 -04:00
|
|
|
m_controller = std::make_shared<PIDController>(p, i, d, this, this);
|
2013-12-15 18:30:16 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
2015-06-25 15:07:55 -04:00
|
|
|
* Instantiates a {@link PIDSubsystem} that will use the given p, i and d
|
|
|
|
|
* values.
|
2016-05-20 17:30:37 -07:00
|
|
|
*
|
2013-12-15 18:30:16 -05:00
|
|
|
* @param name the name
|
2016-05-20 17:30:37 -07:00
|
|
|
* @param p the proportional value
|
|
|
|
|
* @param i the integral value
|
|
|
|
|
* @param d the derivative value
|
|
|
|
|
* @param f the feedforward value
|
2013-12-15 18:30:16 -05:00
|
|
|
*/
|
2016-05-20 17:30:37 -07:00
|
|
|
PIDSubsystem::PIDSubsystem(const std::string& name, double p, double i,
|
|
|
|
|
double d, double f)
|
2015-06-25 15:07:55 -04:00
|
|
|
: Subsystem(name) {
|
2015-09-16 21:40:39 -07:00
|
|
|
m_controller = std::make_shared<PIDController>(p, i, d, f, this, this);
|
2013-12-15 18:30:16 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
2015-06-25 15:07:55 -04:00
|
|
|
* Instantiates a {@link PIDSubsystem} that will use the given p, i and d
|
2016-05-20 17:30:37 -07:00
|
|
|
* values.
|
|
|
|
|
*
|
|
|
|
|
* It will also space the time between PID loop calculations to be equal to the
|
|
|
|
|
* given period.
|
|
|
|
|
*
|
|
|
|
|
* @param name the name
|
|
|
|
|
* @param p the proportional value
|
|
|
|
|
* @param i the integral value
|
|
|
|
|
* @param d the derivative value
|
|
|
|
|
* @param f the feedfoward value
|
2013-12-15 18:30:16 -05:00
|
|
|
* @param period the time (in seconds) between calculations
|
|
|
|
|
*/
|
2016-05-20 17:30:37 -07:00
|
|
|
PIDSubsystem::PIDSubsystem(const std::string& name, double p, double i,
|
|
|
|
|
double d, double f, double period)
|
2015-06-25 15:07:55 -04:00
|
|
|
: Subsystem(name) {
|
2016-05-20 17:30:37 -07:00
|
|
|
m_controller =
|
|
|
|
|
std::make_shared<PIDController>(p, i, d, f, this, this, period);
|
2013-12-15 18:30:16 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
2015-06-25 15:07:55 -04:00
|
|
|
* Instantiates a {@link PIDSubsystem} that will use the given p, i and d
|
|
|
|
|
* values.
|
2016-05-20 17:30:37 -07:00
|
|
|
*
|
2013-12-15 18:30:16 -05:00
|
|
|
* It will use the class name as its name.
|
2016-05-20 17:30:37 -07:00
|
|
|
*
|
2013-12-15 18:30:16 -05:00
|
|
|
* @param p the proportional value
|
|
|
|
|
* @param i the integral value
|
|
|
|
|
* @param d the derivative value
|
|
|
|
|
*/
|
2015-06-25 15:07:55 -04:00
|
|
|
PIDSubsystem::PIDSubsystem(double p, double i, double d)
|
|
|
|
|
: Subsystem("PIDSubsystem") {
|
2015-09-16 21:40:39 -07:00
|
|
|
m_controller = std::make_shared<PIDController>(p, i, d, this, this);
|
2013-12-15 18:30:16 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
2015-06-25 15:07:55 -04:00
|
|
|
* Instantiates a {@link PIDSubsystem} that will use the given p, i and d
|
|
|
|
|
* values.
|
2016-05-20 17:30:37 -07:00
|
|
|
*
|
2013-12-15 18:30:16 -05:00
|
|
|
* It will use the class name as its name.
|
2016-05-20 17:30:37 -07:00
|
|
|
*
|
2013-12-15 18:30:16 -05:00
|
|
|
* @param p the proportional value
|
|
|
|
|
* @param i the integral value
|
|
|
|
|
* @param d the derivative value
|
|
|
|
|
* @param f the feedforward value
|
|
|
|
|
*/
|
2015-06-25 15:07:55 -04:00
|
|
|
PIDSubsystem::PIDSubsystem(double p, double i, double d, double f)
|
|
|
|
|
: Subsystem("PIDSubsystem") {
|
2015-09-16 21:40:39 -07:00
|
|
|
m_controller = std::make_shared<PIDController>(p, i, d, f, this, this);
|
2013-12-15 18:30:16 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
2015-06-25 15:07:55 -04:00
|
|
|
* Instantiates a {@link PIDSubsystem} that will use the given p, i and d
|
|
|
|
|
* values.
|
2016-05-20 17:30:37 -07:00
|
|
|
*
|
|
|
|
|
* It will use the class name as its name. It will also space the time
|
2013-12-15 18:30:16 -05:00
|
|
|
* between PID loop calculations to be equal to the given period.
|
2016-05-20 17:30:37 -07:00
|
|
|
*
|
|
|
|
|
* @param p the proportional value
|
|
|
|
|
* @param i the integral value
|
|
|
|
|
* @param d the derivative value
|
|
|
|
|
* @param f the feedforward value
|
2013-12-15 18:30:16 -05:00
|
|
|
* @param period the time (in seconds) between calculations
|
|
|
|
|
*/
|
2015-06-25 15:07:55 -04:00
|
|
|
PIDSubsystem::PIDSubsystem(double p, double i, double d, double f,
|
|
|
|
|
double period)
|
|
|
|
|
: Subsystem("PIDSubsystem") {
|
2016-05-20 17:30:37 -07:00
|
|
|
m_controller =
|
|
|
|
|
std::make_shared<PIDController>(p, i, d, f, this, this, period);
|
2013-12-15 18:30:16 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
2016-05-20 17:30:37 -07:00
|
|
|
* Enables the internal {@link PIDController}.
|
2013-12-15 18:30:16 -05:00
|
|
|
*/
|
2015-06-25 15:07:55 -04:00
|
|
|
void PIDSubsystem::Enable() { m_controller->Enable(); }
|
2013-12-15 18:30:16 -05:00
|
|
|
|
2014-08-05 14:02:11 -04:00
|
|
|
/**
|
2016-05-20 17:30:37 -07:00
|
|
|
* Disables the internal {@link PIDController}.
|
2013-12-15 18:30:16 -05:00
|
|
|
*/
|
2015-06-25 15:07:55 -04:00
|
|
|
void PIDSubsystem::Disable() { m_controller->Disable(); }
|
2013-12-15 18:30:16 -05:00
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Returns the {@link PIDController} used by this {@link PIDSubsystem}.
|
2016-05-20 17:30:37 -07:00
|
|
|
*
|
2013-12-15 18:30:16 -05:00
|
|
|
* Use this if you would like to fine tune the pid loop.
|
|
|
|
|
*
|
|
|
|
|
* @return the {@link PIDController} used by this {@link PIDSubsystem}
|
|
|
|
|
*/
|
2015-07-24 19:19:40 -04:00
|
|
|
std::shared_ptr<PIDController> PIDSubsystem::GetPIDController() {
|
|
|
|
|
return m_controller;
|
|
|
|
|
}
|
2013-12-15 18:30:16 -05:00
|
|
|
|
|
|
|
|
/**
|
2016-05-20 17:30:37 -07:00
|
|
|
* Sets the setpoint to the given value.
|
|
|
|
|
*
|
|
|
|
|
* If {@link PIDCommand#SetRange(double, double) SetRange(...)} was called,
|
|
|
|
|
* then the given setpoint will be trimmed to fit within the range.
|
|
|
|
|
*
|
2013-12-15 18:30:16 -05:00
|
|
|
* @param setpoint the new setpoint
|
|
|
|
|
*/
|
2015-06-25 15:07:55 -04:00
|
|
|
void PIDSubsystem::SetSetpoint(double setpoint) {
|
|
|
|
|
m_controller->SetSetpoint(setpoint);
|
2013-12-15 18:30:16 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Adds the given value to the setpoint.
|
2016-05-20 17:30:37 -07:00
|
|
|
*
|
2013-12-15 18:30:16 -05:00
|
|
|
* If {@link PIDCommand#SetRange(double, double) SetRange(...)} was used,
|
|
|
|
|
* then the bounds will still be honored by this method.
|
2016-05-20 17:30:37 -07:00
|
|
|
*
|
2013-12-15 18:30:16 -05:00
|
|
|
* @param deltaSetpoint the change in the setpoint
|
|
|
|
|
*/
|
2015-06-25 15:07:55 -04:00
|
|
|
void PIDSubsystem::SetSetpointRelative(double deltaSetpoint) {
|
|
|
|
|
SetSetpoint(GetSetpoint() + deltaSetpoint);
|
2013-12-15 18:30:16 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
2016-05-20 17:30:37 -07:00
|
|
|
* Return the current setpoint.
|
|
|
|
|
*
|
2013-12-15 18:30:16 -05:00
|
|
|
* @return The current setpoint
|
|
|
|
|
*/
|
2015-06-25 15:07:55 -04:00
|
|
|
double PIDSubsystem::GetSetpoint() { return m_controller->GetSetpoint(); }
|
2013-12-15 18:30:16 -05:00
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Sets the maximum and minimum values expected from the input.
|
2014-08-05 14:02:11 -04:00
|
|
|
*
|
2013-12-15 18:30:16 -05:00
|
|
|
* @param minimumInput the minimum value expected from the input
|
|
|
|
|
* @param maximumInput the maximum value expected from the output
|
|
|
|
|
*/
|
2016-11-20 07:25:03 -08:00
|
|
|
void PIDSubsystem::SetInputRange(double minimumInput, double maximumInput) {
|
2015-06-25 15:07:55 -04:00
|
|
|
m_controller->SetInputRange(minimumInput, maximumInput);
|
2013-12-15 18:30:16 -05:00
|
|
|
}
|
|
|
|
|
|
2014-08-05 14:02:11 -04:00
|
|
|
/**
|
|
|
|
|
* Sets the maximum and minimum values to write.
|
|
|
|
|
*
|
|
|
|
|
* @param minimumOutput the minimum value to write to the output
|
|
|
|
|
* @param maximumOutput the maximum value to write to the output
|
|
|
|
|
*/
|
2016-11-20 07:25:03 -08:00
|
|
|
void PIDSubsystem::SetOutputRange(double minimumOutput, double maximumOutput) {
|
2015-06-25 15:07:55 -04:00
|
|
|
m_controller->SetOutputRange(minimumOutput, maximumOutput);
|
2014-08-05 14:02:11 -04:00
|
|
|
}
|
|
|
|
|
|
2016-05-20 17:30:37 -07:00
|
|
|
/**
|
2013-12-15 18:30:16 -05:00
|
|
|
* Set the absolute error which is considered tolerable for use with
|
|
|
|
|
* OnTarget.
|
2016-05-20 17:30:37 -07:00
|
|
|
*
|
|
|
|
|
* @param absValue absolute error which is tolerable
|
2013-12-15 18:30:16 -05:00
|
|
|
*/
|
2016-11-20 07:25:03 -08:00
|
|
|
void PIDSubsystem::SetAbsoluteTolerance(double absValue) {
|
2015-06-25 15:07:55 -04:00
|
|
|
m_controller->SetAbsoluteTolerance(absValue);
|
2013-12-15 18:30:16 -05:00
|
|
|
}
|
|
|
|
|
|
2016-05-20 17:30:37 -07:00
|
|
|
/**
|
|
|
|
|
* Set the percentage error which is considered tolerable for use with OnTarget.
|
|
|
|
|
*
|
|
|
|
|
* @param percent percentage error which is tolerable
|
2013-12-15 18:30:16 -05:00
|
|
|
*/
|
2016-11-20 07:25:03 -08:00
|
|
|
void PIDSubsystem::SetPercentTolerance(double percent) {
|
2015-06-25 15:07:55 -04:00
|
|
|
m_controller->SetPercentTolerance(percent);
|
2013-12-15 18:30:16 -05:00
|
|
|
}
|
|
|
|
|
|
2016-05-20 17:30:37 -07:00
|
|
|
/**
|
2013-12-15 18:30:16 -05:00
|
|
|
* Return true if the error is within the percentage of the total input range,
|
2016-05-20 17:30:37 -07:00
|
|
|
* determined by SetTolerance.
|
|
|
|
|
*
|
|
|
|
|
* This asssumes that the maximum and minimum input were set using SetInput.
|
|
|
|
|
* Use OnTarget() in the IsFinished() method of commands that use this
|
|
|
|
|
* subsystem.
|
2014-08-05 14:02:11 -04:00
|
|
|
*
|
2015-06-25 15:07:55 -04:00
|
|
|
* Currently this just reports on target as the actual value passes through the
|
2016-05-20 17:30:37 -07:00
|
|
|
* setpoint. Ideally it should be based on being within the tolerance for some
|
|
|
|
|
* period of time.
|
2014-08-05 14:02:11 -04:00
|
|
|
*
|
2015-06-25 15:07:55 -04:00
|
|
|
* @return true if the error is within the percentage tolerance of the input
|
2016-05-20 17:30:37 -07:00
|
|
|
* range
|
2013-12-15 18:30:16 -05:00
|
|
|
*/
|
2015-06-25 15:07:55 -04:00
|
|
|
bool PIDSubsystem::OnTarget() const { return m_controller->OnTarget(); }
|
2013-12-15 18:30:16 -05:00
|
|
|
|
|
|
|
|
/**
|
2016-05-20 17:30:37 -07:00
|
|
|
* Returns the current position.
|
|
|
|
|
*
|
2013-12-15 18:30:16 -05:00
|
|
|
* @return the current position
|
|
|
|
|
*/
|
2015-06-25 15:07:55 -04:00
|
|
|
double PIDSubsystem::GetPosition() { return ReturnPIDInput(); }
|
2013-12-15 18:30:16 -05:00
|
|
|
|
2015-07-14 20:37:52 -07:00
|
|
|
/**
|
2016-05-20 17:30:37 -07:00
|
|
|
* Returns the current rate.
|
|
|
|
|
*
|
2015-07-14 20:37:52 -07:00
|
|
|
* @return the current rate
|
|
|
|
|
*/
|
|
|
|
|
double PIDSubsystem::GetRate() { return ReturnPIDInput(); }
|
|
|
|
|
|
2016-11-20 07:25:03 -08:00
|
|
|
void PIDSubsystem::PIDWrite(double output) { UsePIDOutput(output); }
|
2013-12-15 18:30:16 -05:00
|
|
|
|
Revert changes preventing old user code from compiling.
I'm not 100% sure whether we want these, but they are a quick
find and replace to do.
Basically, there are two primary things that we have done
this summer that break existing user code:
-Changing GetInstance() calls to return references instead
of pointers. This forces users to change from doing something
like LiveWindow::GetInstance()->AddSensor() to LiveWindow::GetInstance().AddSensor().
-Making PIDGet() and related calls const, forcing users to change
the function signatures wherever they override them.
The GetInstance() calls don't really matter to me either way,
especially since there are no real ownership issues going on there,
unlike the rest of the smart pointer-related changes.
For the const stuff, it is certainly more correct to mandate that
user PIDGet() functions be const and the such, but at the same time,
I'm not sure that there is any strong need for it, and the errors
generated are not the most helpful. While this wouldn't necessarily
be an issue for more experienced teams or completely new teams (who
don't have any old code to be reusing), it may cause issues for more
average teams who aren't familiar with the intricacies of C++ anything.
Change-Id: I6e7007982069292ea70e6d0fc8ca40203340df1b
2015-07-24 19:19:40 -04:00
|
|
|
double PIDSubsystem::PIDGet() { return ReturnPIDInput(); }
|
2013-12-15 18:30:16 -05:00
|
|
|
|
2015-06-25 15:07:55 -04:00
|
|
|
std::string PIDSubsystem::GetSmartDashboardType() const { return "PIDCommand"; }
|
2016-07-10 17:47:44 -07:00
|
|
|
|
|
|
|
|
void PIDSubsystem::InitTable(std::shared_ptr<ITable> subtable) {
|
|
|
|
|
m_controller->InitTable(subtable);
|
|
|
|
|
Subsystem::InitTable(subtable);
|
2013-12-15 18:30:16 -05:00
|
|
|
}
|