2013-12-15 18:30:16 -05:00
|
|
|
/*----------------------------------------------------------------------------*/
|
2017-08-23 22:06:13 -07:00
|
|
|
/* Copyright (c) 2008-2017 FIRST. All Rights Reserved. */
|
2013-12-15 18:30:16 -05:00
|
|
|
/* Open Source Software - may be modified and shared by FRC teams. The code */
|
2016-01-02 03:02:34 -08:00
|
|
|
/* must be accompanied by the FIRST BSD license file in the root directory of */
|
|
|
|
|
/* the project. */
|
2013-12-15 18:30:16 -05:00
|
|
|
/*----------------------------------------------------------------------------*/
|
|
|
|
|
|
|
|
|
|
#include "MotorSafetyHelper.h"
|
|
|
|
|
|
2017-08-27 00:11:52 -07:00
|
|
|
#include <llvm/SmallString.h>
|
|
|
|
|
#include <llvm/raw_ostream.h>
|
|
|
|
|
|
2013-12-15 18:30:16 -05:00
|
|
|
#include "DriverStation.h"
|
|
|
|
|
#include "MotorSafety.h"
|
|
|
|
|
#include "Timer.h"
|
|
|
|
|
#include "WPIErrors.h"
|
|
|
|
|
|
2016-11-01 22:33:12 -07:00
|
|
|
using namespace frc;
|
|
|
|
|
|
2015-07-29 16:48:04 -04:00
|
|
|
std::set<MotorSafetyHelper*> MotorSafetyHelper::m_helperList;
|
2017-11-13 09:51:48 -08:00
|
|
|
wpi::mutex MotorSafetyHelper::m_listMutex;
|
2013-12-15 18:30:16 -05:00
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* The constructor for a MotorSafetyHelper object.
|
2016-05-20 17:30:37 -07:00
|
|
|
*
|
2015-06-25 15:07:55 -04:00
|
|
|
* The helper object is constructed for every object that wants to implement the
|
2016-05-20 17:30:37 -07:00
|
|
|
* Motor Safety protocol. The helper object has the code to actually do the
|
|
|
|
|
* timing and call the motors Stop() method when the timeout expires. The motor
|
|
|
|
|
* object is expected to call the Feed() method whenever the motors value is
|
|
|
|
|
* updated.
|
|
|
|
|
*
|
2015-06-25 15:07:55 -04:00
|
|
|
* @param safeObject a pointer to the motor object implementing MotorSafety.
|
2016-05-20 17:30:37 -07:00
|
|
|
* This is used to call the Stop() method on the motor.
|
2013-12-15 18:30:16 -05:00
|
|
|
*/
|
2016-05-20 17:30:37 -07:00
|
|
|
MotorSafetyHelper::MotorSafetyHelper(MotorSafety* safeObject)
|
artf4154: Get rid of raw pointers in C++.
This deals with the majority of the user-facing code
in wpilibC++Devices and a substantial portion of it in
wpilibC++. wpilibC++Sim and wpilibC++IntegrationTests
are untouched except where it is necessary to make them
work with the rest of the libraries.
There is still a lot to do in the following areas:
-The HAL (which we may not want to touch at all).
-The I2C, Serial, and SPI interfaces in wpilibC++Devices,
which I haven't gotten around to doing yet.
-Most wpilibC++Devices classes have void* pointers
for interacting with the HAL.
-InterruptableSensorBase passes a void *params for
the interrupt handler.
-I haven't converted all the const char* to std::strings.
-There are plenty of other cases of raw pointers still
existing.
-This doesn't fall directly under raw pointer stuff,
but move syntax and rvalue references could be introduced
in many places.
-I haven't touched vision code.
-The Resource classes conflict (one is in the hal, the other
in wpilibC++). Someone should figure out a more
permanent fix (eg, just renaming them), then doing
what I did (making a new namespace for one of them,
essentially the same as renaming it).
A few other things:
-I created a NullDeleter class which is marked as deprecated.
What this does is it can be passed as the deleter to a
std::shared_ptr so that when you are converting raw pointers
to shared_ptrs the shared_ptr doesn't do any deletion if
someone else owns the raw pointer. This should only be
used in making old raw pointer UIs.
-I had to alter the build.gradle so that it did not
emit errors when deprecated functions called deprecated
functions. Unfortunately, gradle doesn't appear to be
actually printing out gcc warnigns for some reason.
The best way I have found to fix this is to patch
the toolchains (https://bitbucket.org/byteit101/toolchain-builder/pull-request/5/make-gcc-not-throw-warnings-for-nested/diff)
so that a deprecated function calling a deprecated
function is fine but a non-deprecated function calling
a deprecated function will throw a warning (which we
then elevate with -Werror). I believe that clang
deals with this properly, although I have not
tried it myself.
Change-Id: Ib8090c66893576fe73654f4e9d268f9d37be06a2
2015-06-30 15:01:20 -04:00
|
|
|
: m_safeObject(safeObject) {
|
2015-06-25 15:07:55 -04:00
|
|
|
m_enabled = false;
|
|
|
|
|
m_expiration = DEFAULT_SAFETY_EXPIRATION;
|
|
|
|
|
m_stopTime = Timer::GetFPGATimestamp();
|
|
|
|
|
|
2017-11-22 17:10:21 -08:00
|
|
|
std::lock_guard<wpi::mutex> lock(m_listMutex);
|
artf4154: Get rid of raw pointers in C++.
This deals with the majority of the user-facing code
in wpilibC++Devices and a substantial portion of it in
wpilibC++. wpilibC++Sim and wpilibC++IntegrationTests
are untouched except where it is necessary to make them
work with the rest of the libraries.
There is still a lot to do in the following areas:
-The HAL (which we may not want to touch at all).
-The I2C, Serial, and SPI interfaces in wpilibC++Devices,
which I haven't gotten around to doing yet.
-Most wpilibC++Devices classes have void* pointers
for interacting with the HAL.
-InterruptableSensorBase passes a void *params for
the interrupt handler.
-I haven't converted all the const char* to std::strings.
-There are plenty of other cases of raw pointers still
existing.
-This doesn't fall directly under raw pointer stuff,
but move syntax and rvalue references could be introduced
in many places.
-I haven't touched vision code.
-The Resource classes conflict (one is in the hal, the other
in wpilibC++). Someone should figure out a more
permanent fix (eg, just renaming them), then doing
what I did (making a new namespace for one of them,
essentially the same as renaming it).
A few other things:
-I created a NullDeleter class which is marked as deprecated.
What this does is it can be passed as the deleter to a
std::shared_ptr so that when you are converting raw pointers
to shared_ptrs the shared_ptr doesn't do any deletion if
someone else owns the raw pointer. This should only be
used in making old raw pointer UIs.
-I had to alter the build.gradle so that it did not
emit errors when deprecated functions called deprecated
functions. Unfortunately, gradle doesn't appear to be
actually printing out gcc warnigns for some reason.
The best way I have found to fix this is to patch
the toolchains (https://bitbucket.org/byteit101/toolchain-builder/pull-request/5/make-gcc-not-throw-warnings-for-nested/diff)
so that a deprecated function calling a deprecated
function is fine but a non-deprecated function calling
a deprecated function will throw a warning (which we
then elevate with -Werror). I believe that clang
deals with this properly, although I have not
tried it myself.
Change-Id: Ib8090c66893576fe73654f4e9d268f9d37be06a2
2015-06-30 15:01:20 -04:00
|
|
|
m_helperList.insert(this);
|
2013-12-15 18:30:16 -05:00
|
|
|
}
|
|
|
|
|
|
2015-06-25 15:07:55 -04:00
|
|
|
MotorSafetyHelper::~MotorSafetyHelper() {
|
2017-11-22 17:10:21 -08:00
|
|
|
std::lock_guard<wpi::mutex> lock(m_listMutex);
|
artf4154: Get rid of raw pointers in C++.
This deals with the majority of the user-facing code
in wpilibC++Devices and a substantial portion of it in
wpilibC++. wpilibC++Sim and wpilibC++IntegrationTests
are untouched except where it is necessary to make them
work with the rest of the libraries.
There is still a lot to do in the following areas:
-The HAL (which we may not want to touch at all).
-The I2C, Serial, and SPI interfaces in wpilibC++Devices,
which I haven't gotten around to doing yet.
-Most wpilibC++Devices classes have void* pointers
for interacting with the HAL.
-InterruptableSensorBase passes a void *params for
the interrupt handler.
-I haven't converted all the const char* to std::strings.
-There are plenty of other cases of raw pointers still
existing.
-This doesn't fall directly under raw pointer stuff,
but move syntax and rvalue references could be introduced
in many places.
-I haven't touched vision code.
-The Resource classes conflict (one is in the hal, the other
in wpilibC++). Someone should figure out a more
permanent fix (eg, just renaming them), then doing
what I did (making a new namespace for one of them,
essentially the same as renaming it).
A few other things:
-I created a NullDeleter class which is marked as deprecated.
What this does is it can be passed as the deleter to a
std::shared_ptr so that when you are converting raw pointers
to shared_ptrs the shared_ptr doesn't do any deletion if
someone else owns the raw pointer. This should only be
used in making old raw pointer UIs.
-I had to alter the build.gradle so that it did not
emit errors when deprecated functions called deprecated
functions. Unfortunately, gradle doesn't appear to be
actually printing out gcc warnigns for some reason.
The best way I have found to fix this is to patch
the toolchains (https://bitbucket.org/byteit101/toolchain-builder/pull-request/5/make-gcc-not-throw-warnings-for-nested/diff)
so that a deprecated function calling a deprecated
function is fine but a non-deprecated function calling
a deprecated function will throw a warning (which we
then elevate with -Werror). I believe that clang
deals with this properly, although I have not
tried it myself.
Change-Id: Ib8090c66893576fe73654f4e9d268f9d37be06a2
2015-06-30 15:01:20 -04:00
|
|
|
m_helperList.erase(this);
|
2013-12-15 18:30:16 -05:00
|
|
|
}
|
|
|
|
|
|
2014-12-29 14:09:37 -05:00
|
|
|
/**
|
2013-12-15 18:30:16 -05:00
|
|
|
* Feed the motor safety object.
|
2017-11-16 00:33:51 -08:00
|
|
|
*
|
2013-12-15 18:30:16 -05:00
|
|
|
* Resets the timer on this object that is used to do the timeouts.
|
|
|
|
|
*/
|
2015-06-25 15:07:55 -04:00
|
|
|
void MotorSafetyHelper::Feed() {
|
2017-11-22 17:10:21 -08:00
|
|
|
std::lock_guard<wpi::mutex> lock(m_thisMutex);
|
2015-06-25 15:07:55 -04:00
|
|
|
m_stopTime = Timer::GetFPGATimestamp() + m_expiration;
|
2013-12-15 18:30:16 -05:00
|
|
|
}
|
|
|
|
|
|
2014-12-29 14:09:37 -05:00
|
|
|
/**
|
2013-12-15 18:30:16 -05:00
|
|
|
* Set the expiration time for the corresponding motor safety object.
|
2017-11-16 00:33:51 -08:00
|
|
|
*
|
2013-12-15 18:30:16 -05:00
|
|
|
* @param expirationTime The timeout value in seconds.
|
|
|
|
|
*/
|
2016-11-20 07:25:03 -08:00
|
|
|
void MotorSafetyHelper::SetExpiration(double expirationTime) {
|
2017-11-22 17:10:21 -08:00
|
|
|
std::lock_guard<wpi::mutex> lock(m_thisMutex);
|
2015-06-25 15:07:55 -04:00
|
|
|
m_expiration = expirationTime;
|
2013-12-15 18:30:16 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Retrieve the timeout value for the corresponding motor safety object.
|
2017-11-16 00:33:51 -08:00
|
|
|
*
|
2014-12-29 14:09:37 -05:00
|
|
|
* @return the timeout value in seconds.
|
2013-12-15 18:30:16 -05:00
|
|
|
*/
|
2016-11-20 07:25:03 -08:00
|
|
|
double MotorSafetyHelper::GetExpiration() const {
|
2017-11-22 17:10:21 -08:00
|
|
|
std::lock_guard<wpi::mutex> lock(m_thisMutex);
|
2015-06-25 15:07:55 -04:00
|
|
|
return m_expiration;
|
2013-12-15 18:30:16 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Determine if the motor is still operating or has timed out.
|
2017-11-16 00:33:51 -08:00
|
|
|
*
|
2015-06-25 15:07:55 -04:00
|
|
|
* @return a true value if the motor is still operating normally and hasn't
|
|
|
|
|
* timed out.
|
2013-12-15 18:30:16 -05:00
|
|
|
*/
|
2015-06-25 15:07:55 -04:00
|
|
|
bool MotorSafetyHelper::IsAlive() const {
|
2017-11-22 17:10:21 -08:00
|
|
|
std::lock_guard<wpi::mutex> lock(m_thisMutex);
|
2015-06-25 15:07:55 -04:00
|
|
|
return !m_enabled || m_stopTime > Timer::GetFPGATimestamp();
|
2013-12-15 18:30:16 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Check if this motor has exceeded its timeout.
|
2017-11-16 00:33:51 -08:00
|
|
|
*
|
2015-06-25 15:07:55 -04:00
|
|
|
* This method is called periodically to determine if this motor has exceeded
|
2016-05-20 17:30:37 -07:00
|
|
|
* its timeout value. If it has, the stop method is called, and the motor is
|
|
|
|
|
* shut down until its value is updated again.
|
2013-12-15 18:30:16 -05:00
|
|
|
*/
|
2015-06-25 15:07:55 -04:00
|
|
|
void MotorSafetyHelper::Check() {
|
2016-05-20 17:30:37 -07:00
|
|
|
DriverStation& ds = DriverStation::GetInstance();
|
artf4154: Get rid of raw pointers in C++.
This deals with the majority of the user-facing code
in wpilibC++Devices and a substantial portion of it in
wpilibC++. wpilibC++Sim and wpilibC++IntegrationTests
are untouched except where it is necessary to make them
work with the rest of the libraries.
There is still a lot to do in the following areas:
-The HAL (which we may not want to touch at all).
-The I2C, Serial, and SPI interfaces in wpilibC++Devices,
which I haven't gotten around to doing yet.
-Most wpilibC++Devices classes have void* pointers
for interacting with the HAL.
-InterruptableSensorBase passes a void *params for
the interrupt handler.
-I haven't converted all the const char* to std::strings.
-There are plenty of other cases of raw pointers still
existing.
-This doesn't fall directly under raw pointer stuff,
but move syntax and rvalue references could be introduced
in many places.
-I haven't touched vision code.
-The Resource classes conflict (one is in the hal, the other
in wpilibC++). Someone should figure out a more
permanent fix (eg, just renaming them), then doing
what I did (making a new namespace for one of them,
essentially the same as renaming it).
A few other things:
-I created a NullDeleter class which is marked as deprecated.
What this does is it can be passed as the deleter to a
std::shared_ptr so that when you are converting raw pointers
to shared_ptrs the shared_ptr doesn't do any deletion if
someone else owns the raw pointer. This should only be
used in making old raw pointer UIs.
-I had to alter the build.gradle so that it did not
emit errors when deprecated functions called deprecated
functions. Unfortunately, gradle doesn't appear to be
actually printing out gcc warnigns for some reason.
The best way I have found to fix this is to patch
the toolchains (https://bitbucket.org/byteit101/toolchain-builder/pull-request/5/make-gcc-not-throw-warnings-for-nested/diff)
so that a deprecated function calling a deprecated
function is fine but a non-deprecated function calling
a deprecated function will throw a warning (which we
then elevate with -Werror). I believe that clang
deals with this properly, although I have not
tried it myself.
Change-Id: Ib8090c66893576fe73654f4e9d268f9d37be06a2
2015-06-30 15:01:20 -04:00
|
|
|
if (!m_enabled || ds.IsDisabled() || ds.IsTest()) return;
|
2015-06-25 15:07:55 -04:00
|
|
|
|
2017-11-22 17:10:21 -08:00
|
|
|
std::lock_guard<wpi::mutex> lock(m_thisMutex);
|
2015-06-25 15:07:55 -04:00
|
|
|
if (m_stopTime < Timer::GetFPGATimestamp()) {
|
2017-05-15 23:10:40 -07:00
|
|
|
llvm::SmallString<128> buf;
|
|
|
|
|
llvm::raw_svector_ostream desc(buf);
|
2015-06-25 15:07:55 -04:00
|
|
|
m_safeObject->GetDescription(desc);
|
2016-05-20 17:30:37 -07:00
|
|
|
desc << "... Output not updated often enough.";
|
2017-05-15 23:10:40 -07:00
|
|
|
wpi_setWPIErrorWithContext(Timeout, desc.str());
|
2015-06-25 15:07:55 -04:00
|
|
|
m_safeObject->StopMotor();
|
|
|
|
|
}
|
2013-12-15 18:30:16 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Enable/disable motor safety for this device
|
2017-11-16 00:33:51 -08:00
|
|
|
*
|
2013-12-15 18:30:16 -05:00
|
|
|
* Turn on and off the motor safety option for this PWM object.
|
2017-11-16 00:33:51 -08:00
|
|
|
*
|
2013-12-15 18:30:16 -05:00
|
|
|
* @param enabled True if motor safety is enforced for this object
|
|
|
|
|
*/
|
2015-06-25 15:07:55 -04:00
|
|
|
void MotorSafetyHelper::SetSafetyEnabled(bool enabled) {
|
2017-11-22 17:10:21 -08:00
|
|
|
std::lock_guard<wpi::mutex> lock(m_thisMutex);
|
2015-06-25 15:07:55 -04:00
|
|
|
m_enabled = enabled;
|
2013-12-15 18:30:16 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Return the state of the motor safety enabled flag
|
2017-11-16 00:33:51 -08:00
|
|
|
*
|
2013-12-15 18:30:16 -05:00
|
|
|
* Return if the motor safety is currently enabled for this devicce.
|
2017-11-16 00:33:51 -08:00
|
|
|
*
|
2014-12-29 14:09:37 -05:00
|
|
|
* @return True if motor safety is enforced for this device
|
2013-12-15 18:30:16 -05:00
|
|
|
*/
|
2015-06-25 15:07:55 -04:00
|
|
|
bool MotorSafetyHelper::IsSafetyEnabled() const {
|
2017-11-22 17:10:21 -08:00
|
|
|
std::lock_guard<wpi::mutex> lock(m_thisMutex);
|
2015-06-25 15:07:55 -04:00
|
|
|
return m_enabled;
|
2013-12-15 18:30:16 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Check the motors to see if any have timed out.
|
2017-11-16 00:33:51 -08:00
|
|
|
*
|
|
|
|
|
* This static method is called periodically to poll all the motors and stop any
|
|
|
|
|
* that have timed out.
|
2013-12-15 18:30:16 -05:00
|
|
|
*/
|
2015-06-25 15:07:55 -04:00
|
|
|
void MotorSafetyHelper::CheckMotors() {
|
2017-11-22 17:10:21 -08:00
|
|
|
std::lock_guard<wpi::mutex> lock(m_listMutex);
|
artf4154: Get rid of raw pointers in C++.
This deals with the majority of the user-facing code
in wpilibC++Devices and a substantial portion of it in
wpilibC++. wpilibC++Sim and wpilibC++IntegrationTests
are untouched except where it is necessary to make them
work with the rest of the libraries.
There is still a lot to do in the following areas:
-The HAL (which we may not want to touch at all).
-The I2C, Serial, and SPI interfaces in wpilibC++Devices,
which I haven't gotten around to doing yet.
-Most wpilibC++Devices classes have void* pointers
for interacting with the HAL.
-InterruptableSensorBase passes a void *params for
the interrupt handler.
-I haven't converted all the const char* to std::strings.
-There are plenty of other cases of raw pointers still
existing.
-This doesn't fall directly under raw pointer stuff,
but move syntax and rvalue references could be introduced
in many places.
-I haven't touched vision code.
-The Resource classes conflict (one is in the hal, the other
in wpilibC++). Someone should figure out a more
permanent fix (eg, just renaming them), then doing
what I did (making a new namespace for one of them,
essentially the same as renaming it).
A few other things:
-I created a NullDeleter class which is marked as deprecated.
What this does is it can be passed as the deleter to a
std::shared_ptr so that when you are converting raw pointers
to shared_ptrs the shared_ptr doesn't do any deletion if
someone else owns the raw pointer. This should only be
used in making old raw pointer UIs.
-I had to alter the build.gradle so that it did not
emit errors when deprecated functions called deprecated
functions. Unfortunately, gradle doesn't appear to be
actually printing out gcc warnigns for some reason.
The best way I have found to fix this is to patch
the toolchains (https://bitbucket.org/byteit101/toolchain-builder/pull-request/5/make-gcc-not-throw-warnings-for-nested/diff)
so that a deprecated function calling a deprecated
function is fine but a non-deprecated function calling
a deprecated function will throw a warning (which we
then elevate with -Werror). I believe that clang
deals with this properly, although I have not
tried it myself.
Change-Id: Ib8090c66893576fe73654f4e9d268f9d37be06a2
2015-06-30 15:01:20 -04:00
|
|
|
for (auto elem : m_helperList) {
|
|
|
|
|
elem->Check();
|
2015-06-25 15:07:55 -04:00
|
|
|
}
|
2013-12-15 18:30:16 -05:00
|
|
|
}
|