2014-06-07 17:37:51 -04:00
|
|
|
/*----------------------------------------------------------------------------*/
|
|
|
|
|
/* Copyright (c) FIRST 2014. All Rights Reserved. */
|
|
|
|
|
/* Open Source Software - may be modified and shared by FRC teams. The code */
|
|
|
|
|
/* must be accompanied by the FIRST BSD license file in the root directory of */
|
|
|
|
|
/* the project. */
|
|
|
|
|
/*----------------------------------------------------------------------------*/
|
|
|
|
|
|
|
|
|
|
#include "WPILib.h"
|
|
|
|
|
#include "gtest/gtest.h"
|
|
|
|
|
#include "TestBench.h"
|
|
|
|
|
|
|
|
|
|
enum MotorEncoderTestType { TEST_VICTOR, TEST_JAGUAR, TEST_TALON };
|
|
|
|
|
|
|
|
|
|
std::ostream &operator<<(std::ostream &os, MotorEncoderTestType const &type) {
|
2015-06-25 15:07:55 -04:00
|
|
|
switch (type) {
|
|
|
|
|
case TEST_VICTOR:
|
|
|
|
|
os << "Victor";
|
|
|
|
|
break;
|
|
|
|
|
case TEST_JAGUAR:
|
|
|
|
|
os << "Jaguar";
|
|
|
|
|
break;
|
|
|
|
|
case TEST_TALON:
|
|
|
|
|
os << "Talon";
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return os;
|
2014-06-07 17:37:51 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static constexpr double kMotorTime = 0.5;
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* A fixture that includes a PWM speed controller and an encoder connected to
|
|
|
|
|
* the same motor.
|
|
|
|
|
* @author Thomas Clark
|
|
|
|
|
*/
|
|
|
|
|
class MotorEncoderTest : public testing::TestWithParam<MotorEncoderTestType> {
|
2015-06-25 15:07:55 -04:00
|
|
|
protected:
|
|
|
|
|
SpeedController *m_speedController;
|
|
|
|
|
Encoder *m_encoder;
|
|
|
|
|
|
|
|
|
|
virtual void SetUp() override {
|
|
|
|
|
switch (GetParam()) {
|
|
|
|
|
case TEST_VICTOR:
|
|
|
|
|
m_speedController = new Victor(TestBench::kVictorChannel);
|
|
|
|
|
m_encoder = new Encoder(TestBench::kVictorEncoderChannelA,
|
|
|
|
|
TestBench::kVictorEncoderChannelB);
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case TEST_JAGUAR:
|
|
|
|
|
m_speedController = new Jaguar(TestBench::kJaguarChannel);
|
|
|
|
|
m_encoder = new Encoder(TestBench::kJaguarEncoderChannelA,
|
|
|
|
|
TestBench::kJaguarEncoderChannelB);
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case TEST_TALON:
|
|
|
|
|
m_speedController = new Talon(TestBench::kTalonChannel);
|
|
|
|
|
m_encoder = new Encoder(TestBench::kTalonEncoderChannelA,
|
|
|
|
|
TestBench::kTalonEncoderChannelB);
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
virtual void TearDown() override {
|
|
|
|
|
delete m_speedController;
|
|
|
|
|
delete m_encoder;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void Reset() {
|
|
|
|
|
m_speedController->Set(0.0f);
|
|
|
|
|
m_encoder->Reset();
|
|
|
|
|
}
|
2014-06-07 17:37:51 -04:00
|
|
|
};
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Test if the encoder value increments after the motor drives forward
|
|
|
|
|
*/
|
|
|
|
|
TEST_P(MotorEncoderTest, Increment) {
|
2015-06-25 15:07:55 -04:00
|
|
|
Reset();
|
2014-08-15 11:22:01 -04:00
|
|
|
|
2015-06-25 15:07:55 -04:00
|
|
|
/* Drive the speed controller briefly to move the encoder */
|
|
|
|
|
m_speedController->Set(1.0);
|
|
|
|
|
Wait(kMotorTime);
|
|
|
|
|
m_speedController->Set(0.0);
|
2014-08-15 11:22:01 -04:00
|
|
|
|
2015-06-25 15:07:55 -04:00
|
|
|
/* The encoder should be positive now */
|
|
|
|
|
EXPECT_GT(m_encoder->Get(), 0)
|
|
|
|
|
<< "Encoder should have incremented after the motor moved";
|
2014-06-07 17:37:51 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Test if the encoder value decrements after the motor drives backwards
|
|
|
|
|
*/
|
|
|
|
|
TEST_P(MotorEncoderTest, Decrement) {
|
2015-06-25 15:07:55 -04:00
|
|
|
Reset();
|
2014-08-15 11:22:01 -04:00
|
|
|
|
2015-06-25 15:07:55 -04:00
|
|
|
/* Drive the speed controller briefly to move the encoder */
|
|
|
|
|
m_speedController->Set(-1.0f);
|
|
|
|
|
Wait(kMotorTime);
|
|
|
|
|
m_speedController->Set(0.0f);
|
2014-08-15 11:22:01 -04:00
|
|
|
|
2015-06-25 15:07:55 -04:00
|
|
|
/* The encoder should be positive now */
|
|
|
|
|
EXPECT_LT(m_encoder->Get(), 0.0f)
|
|
|
|
|
<< "Encoder should have decremented after the motor moved";
|
2014-06-07 17:37:51 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Test if motor speeds are clamped to [-1,1]
|
|
|
|
|
*/
|
|
|
|
|
TEST_P(MotorEncoderTest, ClampSpeed) {
|
2015-06-25 15:07:55 -04:00
|
|
|
Reset();
|
2014-08-15 11:22:01 -04:00
|
|
|
|
2015-06-25 15:07:55 -04:00
|
|
|
m_speedController->Set(2.0f);
|
|
|
|
|
Wait(kMotorTime);
|
2014-08-15 11:22:01 -04:00
|
|
|
|
2015-06-25 15:07:55 -04:00
|
|
|
EXPECT_FLOAT_EQ(1.0f, m_speedController->Get());
|
2014-08-15 11:22:01 -04:00
|
|
|
|
2015-06-25 15:07:55 -04:00
|
|
|
m_speedController->Set(-2.0f);
|
|
|
|
|
Wait(kMotorTime);
|
2014-08-15 11:22:01 -04:00
|
|
|
|
2015-06-25 15:07:55 -04:00
|
|
|
EXPECT_FLOAT_EQ(-1.0f, m_speedController->Get());
|
2014-06-07 17:37:51 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
2015-07-14 20:37:52 -07:00
|
|
|
* Test if position PID loop works
|
2014-06-07 17:37:51 -04:00
|
|
|
*/
|
2015-07-14 20:37:52 -07:00
|
|
|
TEST_P(MotorEncoderTest, PositionPIDController) {
|
2015-06-25 15:07:55 -04:00
|
|
|
Reset();
|
2014-08-15 11:22:01 -04:00
|
|
|
|
2015-07-14 20:37:52 -07:00
|
|
|
m_encoder->SetPIDSourceType(PIDSourceType::kDisplacement);
|
2015-06-25 15:07:55 -04:00
|
|
|
PIDController pid(0.001f, 0.0005f, 0.0f, m_encoder, m_speedController);
|
|
|
|
|
pid.SetAbsoluteTolerance(20.0f);
|
|
|
|
|
pid.SetOutputRange(-0.3f, 0.3f);
|
|
|
|
|
pid.SetSetpoint(2500);
|
2014-08-15 11:22:01 -04:00
|
|
|
|
2015-06-25 15:07:55 -04:00
|
|
|
/* 10 seconds should be plenty time to get to the setpoint */
|
|
|
|
|
pid.Enable();
|
|
|
|
|
Wait(10.0);
|
|
|
|
|
pid.Disable();
|
2014-08-15 11:22:01 -04:00
|
|
|
|
2015-06-25 15:07:55 -04:00
|
|
|
RecordProperty("PIDError", pid.GetError());
|
2014-08-15 11:22:01 -04:00
|
|
|
|
2015-06-25 15:07:55 -04:00
|
|
|
EXPECT_TRUE(pid.OnTarget()) << "PID loop did not converge within 10 seconds.";
|
2014-06-07 17:37:51 -04:00
|
|
|
}
|
|
|
|
|
|
2015-07-14 20:37:52 -07:00
|
|
|
/**
|
|
|
|
|
* Test if velocity PID loop works
|
|
|
|
|
*/
|
|
|
|
|
TEST_P(MotorEncoderTest, VelocityPIDController) {
|
|
|
|
|
Reset();
|
|
|
|
|
|
|
|
|
|
m_encoder->SetPIDSourceType(PIDSourceType::kRate);
|
2015-07-16 14:45:07 -04:00
|
|
|
PIDController pid(1e-5, 0.0f, 3e-5, 8e-5, m_encoder, m_speedController);
|
|
|
|
|
pid.SetAbsoluteTolerance(50.0f);
|
|
|
|
|
pid.SetToleranceBuffer(10);
|
2015-07-14 20:37:52 -07:00
|
|
|
pid.SetOutputRange(-0.3f, 0.3f);
|
2015-07-16 14:45:07 -04:00
|
|
|
pid.SetSetpoint(2000);
|
2015-07-14 20:37:52 -07:00
|
|
|
|
|
|
|
|
/* 10 seconds should be plenty time to get to the setpoint */
|
|
|
|
|
pid.Enable();
|
|
|
|
|
Wait(10.0);
|
|
|
|
|
|
2015-07-16 14:45:07 -04:00
|
|
|
RecordProperty("PIDError", pid.GetAvgError());
|
2015-07-14 20:37:52 -07:00
|
|
|
|
2015-07-16 14:45:07 -04:00
|
|
|
EXPECT_TRUE(pid.OnTarget()) << "PID loop did not converge within 10 seconds. Goal was: " << 2000 << " Error was: " << pid.GetError();
|
2015-07-14 20:37:52 -07:00
|
|
|
|
|
|
|
|
pid.Disable();
|
|
|
|
|
}
|
|
|
|
|
|
2014-06-07 17:37:51 -04:00
|
|
|
/**
|
|
|
|
|
* Test resetting encoders
|
|
|
|
|
*/
|
|
|
|
|
TEST_P(MotorEncoderTest, Reset) {
|
2015-06-25 15:07:55 -04:00
|
|
|
Reset();
|
2014-08-15 11:22:01 -04:00
|
|
|
|
2015-06-25 15:07:55 -04:00
|
|
|
EXPECT_EQ(0, m_encoder->Get()) << "Encoder did not reset to 0";
|
2014-06-07 17:37:51 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
INSTANTIATE_TEST_CASE_P(Test, MotorEncoderTest,
|
2015-06-25 15:07:55 -04:00
|
|
|
testing::Values(TEST_VICTOR, TEST_JAGUAR, TEST_TALON));
|