From 008232b43ced3c5b05dccb7563c480905c762a32 Mon Sep 17 00:00:00 2001 From: Peter Johnson Date: Sat, 21 Jan 2023 22:09:24 -0800 Subject: [PATCH] [ntcore] Write empty persistent file if none found (#4996) This avoids the warning appearing on every startup when persistent values aren't used. Also add note to message saying it can be ignored if persistent values aren't expected. --- ntcore/src/main/native/cpp/NetworkServer.cpp | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/ntcore/src/main/native/cpp/NetworkServer.cpp b/ntcore/src/main/native/cpp/NetworkServer.cpp index 0086d24834..4609544453 100644 --- a/ntcore/src/main/native/cpp/NetworkServer.cpp +++ b/ntcore/src/main/native/cpp/NetworkServer.cpp @@ -360,8 +360,16 @@ void NSImpl::LoadPersistent() { auto size = fs::file_size(m_persistentFilename, ec); wpi::raw_fd_istream is{m_persistentFilename, ec}; if (ec.value() != 0) { - INFO("could not open persistent file '{}': {}", m_persistentFilename, - ec.message()); + INFO( + "could not open persistent file '{}': {} " + "(this can be ignored if you aren't expecting persistent values)", + m_persistentFilename, ec.message()); + // try to write an empty file so it doesn't happen again + wpi::raw_fd_ostream os{m_persistentFilename, ec, fs::F_Text}; + if (ec.value() == 0) { + os << "[]\n"; + os.close(); + } return; } is.readinto(m_persistentData, size);