From 0277759d44b99445bdc40bae996938a52beec245 Mon Sep 17 00:00:00 2001 From: Gold856 <117957790+Gold856@users.noreply.github.com> Date: Sun, 28 Sep 2025 19:00:35 -0400 Subject: [PATCH] [wpiunits] Remove redundant if statement and inaccurate comment (#8262) --- .../main/java/edu/wpi/first/units/Measure.java | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/wpiunits/src/main/java/edu/wpi/first/units/Measure.java b/wpiunits/src/main/java/edu/wpi/first/units/Measure.java index 6a436194b7..46b242b74a 100644 --- a/wpiunits/src/main/java/edu/wpi/first/units/Measure.java +++ b/wpiunits/src/main/java/edu/wpi/first/units/Measure.java @@ -665,17 +665,10 @@ public interface Measure extends Comparable> { return unit().ofBaseUnits(baseUnitResult); } - if (unit() instanceof DimensionlessUnit) { - // Numerator is a dimensionless - if (divisor.unit() instanceof PerUnit ratio) { - // Dividing by a ratio, return its reciprocal scaled by this - return ratio.reciprocal().ofBaseUnits(baseUnitResult); - } - if (divisor.unit() instanceof PerUnit ratio) { - // Dividing by a Per, return its reciprocal velocity scaled by this - // Note: Per.reciprocal() is coded to return a Velocity - return ratio.reciprocal().ofBaseUnits(baseUnitResult); - } + // Numerator is a dimensionless + if (unit() instanceof DimensionlessUnit && divisor.unit() instanceof PerUnit ratio) { + // Dividing by a ratio, return its reciprocal scaled by this + return ratio.reciprocal().ofBaseUnits(baseUnitResult); } if (divisor.unit() instanceof PerUnit ratio