Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-19 00:41:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

[wpiunits] Remove redundant if statement and inaccurate comment (#8262)

Browse Source
This commit is contained in:
Gold856
2025-09-28 19:00:35 -04:00
committed by GitHub
parent f9899eb73f
commit 0277759d44
1 changed files with 4 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
wpiunits/src/main/java/edu/wpi/first/units/Measure.java
View File

@@ -665,17 +665,10 @@ public interface Measure<U extends Unit> extends Comparable<Measure<U>> {
return unit().ofBaseUnits(baseUnitResult);
}
if (unit() instanceof DimensionlessUnit) {
// Numerator is a dimensionless
if (divisor.unit() instanceof PerUnit<?, ?> ratio) {
// Dividing by a ratio, return its reciprocal scaled by this
return ratio.reciprocal().ofBaseUnits(baseUnitResult);
}
if (divisor.unit() instanceof PerUnit<?, ?> ratio) {
// Dividing by a Per<Time, U>, return its reciprocal velocity scaled by this
// Note: Per<Time, U>.reciprocal() is coded to return a Velocity<U>
return ratio.reciprocal().ofBaseUnits(baseUnitResult);
}
// Numerator is a dimensionless
if (unit() instanceof DimensionlessUnit && divisor.unit() instanceof PerUnit<?, ?> ratio) {
// Dividing by a ratio, return its reciprocal scaled by this
return ratio.reciprocal().ofBaseUnits(baseUnitResult);
}
if (divisor.unit() instanceof PerUnit<?, ?> ratio