From 0352a60f38c249aa66f51252d9d658a11b97de63 Mon Sep 17 00:00:00 2001 From: David Vo Date: Tue, 27 Aug 2024 10:32:32 +1000 Subject: [PATCH] Override getMessage in Exceptions instead of toString (#7002) Fixes https://errorprone.info/bugpattern/OverrideThrowableToString --- .../src/main/java/edu/wpi/first/cscore/VideoException.java | 5 ----- .../java/edu/wpi/first/util/struct/BadSchemaException.java | 4 ++-- .../edu/wpi/first/util/struct/parser/ParseException.java | 4 ++-- 3 files changed, 4 insertions(+), 9 deletions(-) diff --git a/cscore/src/main/java/edu/wpi/first/cscore/VideoException.java b/cscore/src/main/java/edu/wpi/first/cscore/VideoException.java index 8b481a77e2..afc16b5112 100644 --- a/cscore/src/main/java/edu/wpi/first/cscore/VideoException.java +++ b/cscore/src/main/java/edu/wpi/first/cscore/VideoException.java @@ -16,9 +16,4 @@ public class VideoException extends RuntimeException { public VideoException(String msg) { super(msg); } - - @Override - public String toString() { - return "VideoException [" + super.toString() + "]"; - } } diff --git a/wpiutil/src/main/java/edu/wpi/first/util/struct/BadSchemaException.java b/wpiutil/src/main/java/edu/wpi/first/util/struct/BadSchemaException.java index 9c69e1f665..ebc3361fe9 100644 --- a/wpiutil/src/main/java/edu/wpi/first/util/struct/BadSchemaException.java +++ b/wpiutil/src/main/java/edu/wpi/first/util/struct/BadSchemaException.java @@ -73,7 +73,7 @@ public class BadSchemaException extends Exception { } @Override - public String toString() { - return m_field.isEmpty() ? getMessage() : "field " + m_field + ": " + getMessage(); + public String getMessage() { + return m_field.isEmpty() ? super.getMessage() : "field " + m_field + ": " + super.getMessage(); } } diff --git a/wpiutil/src/main/java/edu/wpi/first/util/struct/parser/ParseException.java b/wpiutil/src/main/java/edu/wpi/first/util/struct/parser/ParseException.java index 5e71c79ca9..fec3fb4823 100644 --- a/wpiutil/src/main/java/edu/wpi/first/util/struct/parser/ParseException.java +++ b/wpiutil/src/main/java/edu/wpi/first/util/struct/parser/ParseException.java @@ -53,7 +53,7 @@ public class ParseException extends Exception { } @Override - public String toString() { - return m_pos + ": " + getMessage(); + public String getMessage() { + return m_pos + ": " + super.getMessage(); } }