Moves using namespace from ChipObject.h into hal namespace (#323)

hal/lib/athena/Accelerometer.cpp

@@ -16,6 +16,8 @@
 #include "ChipObject.h"
 #include "HAL/HAL.h"
 
+using namespace hal;
+
 // The 7-bit I2C address with a 0 "send" bit
 static const uint8_t kSendAddress = (0x1c << 1) | 0;
 

hal/lib/athena/ChipObject.h

@@ -39,7 +39,9 @@
 #include "FRC_FPGA_ChipObject/nRoboRIO_FPGANamespace/tSPI.h"
 #include "FRC_FPGA_ChipObject/nRoboRIO_FPGANamespace/tSysWatchdog.h"
 
-// FIXME: these should not be here!
-using namespace nFPGA;                   // NOLINT
-using namespace nRoboRIO_FPGANamespace;  // NOLINT
+namespace hal {
+using namespace nFPGA;
+using namespace nRoboRIO_FPGANamespace;
+}  // namespace hal
+
 #pragma GCC diagnostic pop

hal/lib/athena/HAL.cpp

@@ -27,6 +27,8 @@
 #include "ctre/ctre.h"
 #include "visa/visa.h"
 
+using namespace hal;
+
 static std::unique_ptr<tGlobal> global;
 static std::unique_ptr<tSysWatchdog> watchdog;
 

hal/lib/athena/Notifier.cpp

@@ -21,6 +21,8 @@
 #include "HAL/handles/UnlimitedHandleResource.h"
 #include "support/SafeThread.h"
 
+using namespace hal;
+
 static const int32_t kTimerInterruptNumber = 28;
 
 static priority_mutex notifierInterruptMutex;

hal/lib/athena/Power.cpp

@@ -11,6 +11,8 @@
 
 #include "ChipObject.h"
 
+using namespace hal;
+
 static std::unique_ptr<tPower> power;
 
 static void initializePower(int32_t* status) {