Remove redundant C++ lambda parentheses (NFC) (#3433)

This commit is contained in:
Tyler Veness
2021-06-12 08:06:45 -07:00
committed by GitHub
parent f60994ad24
commit 04e64db945
37 changed files with 63 additions and 64 deletions

View File

@@ -230,17 +230,17 @@ void PIDBase::PIDWrite(double output) {
void PIDBase::InitSendable(SendableBuilder& builder) {
builder.SetSmartDashboardType("PIDController");
builder.SetSafeState([=]() { Reset(); });
builder.SetSafeState([=] { Reset(); });
builder.AddDoubleProperty(
"p", [=]() { return GetP(); }, [=](double value) { SetP(value); });
"p", [=] { return GetP(); }, [=](double value) { SetP(value); });
builder.AddDoubleProperty(
"i", [=]() { return GetI(); }, [=](double value) { SetI(value); });
"i", [=] { return GetI(); }, [=](double value) { SetI(value); });
builder.AddDoubleProperty(
"d", [=]() { return GetD(); }, [=](double value) { SetD(value); });
"d", [=] { return GetD(); }, [=](double value) { SetD(value); });
builder.AddDoubleProperty(
"f", [=]() { return GetF(); }, [=](double value) { SetF(value); });
"f", [=] { return GetF(); }, [=](double value) { SetF(value); });
builder.AddDoubleProperty(
"setpoint", [=]() { return GetSetpoint(); },
"setpoint", [=] { return GetSetpoint(); },
[=](double value) { SetSetpoint(value); });
}

View File

@@ -78,6 +78,6 @@ void PIDController::Reset() {
void PIDController::InitSendable(SendableBuilder& builder) {
PIDBase::InitSendable(builder);
builder.AddBooleanProperty(
"enabled", [=]() { return IsEnabled(); },
"enabled", [=] { return IsEnabled(); },
[=](bool value) { SetEnabled(value); });
}

View File

@@ -64,8 +64,8 @@ void Trigger::ToggleWhenActive(Command* command) {
void Trigger::InitSendable(SendableBuilder& builder) {
builder.SetSmartDashboardType("Button");
builder.SetSafeState([=]() { m_sendablePressed = false; });
builder.SetSafeState([=] { m_sendablePressed = false; });
builder.AddBooleanProperty(
"pressed", [=]() { return Grab(); },
"pressed", [=] { return Grab(); },
[=](bool value) { m_sendablePressed = value; });
}

View File

@@ -295,10 +295,10 @@ void Command::SetSubsystem(std::string_view name) {
void Command::InitSendable(SendableBuilder& builder) {
builder.SetSmartDashboardType("Command");
builder.AddStringProperty(
".name", [=]() { return SendableRegistry::GetInstance().GetName(this); },
".name", [=] { return SendableRegistry::GetInstance().GetName(this); },
nullptr);
builder.AddBooleanProperty(
"running", [=]() { return IsRunning(); },
"running", [=] { return IsRunning(); },
[=](bool value) {
if (value) {
if (!IsRunning()) {
@@ -311,5 +311,5 @@ void Command::InitSendable(SendableBuilder& builder) {
}
});
builder.AddBooleanProperty(
".isParented", [=]() { return IsParented(); }, nullptr);
".isParented", [=] { return IsParented(); }, nullptr);
}

View File

@@ -162,7 +162,7 @@ void Scheduler::InitSendable(SendableBuilder& builder) {
auto namesEntry = builder.GetEntry("Names");
auto idsEntry = builder.GetEntry("Ids");
auto cancelEntry = builder.GetEntry("Cancel");
builder.SetUpdateTable([=]() {
builder.SetUpdateTable([=] {
// Get the list of possible commands to cancel
auto new_toCancel = cancelEntry.GetValue();
wpi::span<const double> toCancel;

View File

@@ -125,12 +125,12 @@ void Subsystem::InitSendable(SendableBuilder& builder) {
builder.SetSmartDashboardType("Subsystem");
builder.AddBooleanProperty(
".hasDefault", [=]() { return m_defaultCommand != nullptr; }, nullptr);
".hasDefault", [=] { return m_defaultCommand != nullptr; }, nullptr);
builder.AddStringProperty(
".default", [=]() { return GetDefaultCommandName(); }, nullptr);
".default", [=] { return GetDefaultCommandName(); }, nullptr);
builder.AddBooleanProperty(
".hasCommand", [=]() { return m_currentCommand != nullptr; }, nullptr);
".hasCommand", [=] { return m_currentCommand != nullptr; }, nullptr);
builder.AddStringProperty(
".command", [=]() { return GetCurrentCommandName(); }, nullptr);
".command", [=] { return GetCurrentCommandName(); }, nullptr);
}