Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-21 01:01:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use StringRef and ArrayRef return values when buf passed.

Browse Source 
For functions where a SmallVector is passed to be used as a stack buffer for
the return value, have the return value be the appropriate StringRef or
ArrayRef type.  This allows for both more natural usage and enables directly
returning (rather than copying) a permanently stored or constant string.
This commit is contained in:
Peter Johnson
2016-09-10 21:30:39 -07:00
parent c4ceec145a
commit 052f746c68
11 changed files with 141 additions and 125 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/SourceImpl.h
View File

@@ -15,6 +15,7 @@
#include <string>
#include <vector>
#include "llvm/ArrayRef.h"
#include "llvm/StringRef.h"
#include "cameraserver_c.h"
#include "Frame.h"
@@ -31,7 +32,8 @@ class SourceImpl {
SourceImpl& operator=(const SourceImpl& queue) = delete;
llvm::StringRef GetName() const { return m_name; }
virtual void GetDescription(llvm::SmallVectorImpl<char>& desc) const = 0;
virtual llvm::StringRef GetDescription(
llvm::SmallVectorImpl<char>& buf) const = 0;
int GetNumChannels() const { return m_numChannels; }
bool IsConnected() const { return m_connected; }
@@ -78,19 +80,19 @@ class SourceImpl {
// Property functions
virtual int GetProperty(llvm::StringRef name) const = 0;
virtual void EnumerateProperties(
llvm::SmallVectorImpl<int>& properties) const = 0;
virtual llvm::ArrayRef<int> EnumerateProperties(
llvm::SmallVectorImpl<int>& vec) const = 0;
virtual CS_PropertyType GetPropertyType(int property) const = 0;
virtual void GetPropertyName(int property,
llvm::SmallVectorImpl<char>& name) const = 0;
virtual llvm::StringRef GetPropertyName(
int property, llvm::SmallVectorImpl<char>& buf) const = 0;
virtual bool GetBooleanProperty(int property) const = 0;
virtual void SetBooleanProperty(int property, bool value) = 0;
virtual double GetDoubleProperty(int property) const = 0;
virtual void SetDoubleProperty(int property, double value) = 0;
virtual double GetPropertyMin(int property) const = 0;
virtual double GetPropertyMax(int property) const = 0;
virtual void GetStringProperty(int property,
llvm::SmallVectorImpl<char>& value) const = 0;
virtual llvm::StringRef GetStringProperty(
int property, llvm::SmallVectorImpl<char>& buf) const = 0;
virtual void SetStringProperty(int property, llvm::StringRef value) = 0;
virtual int GetEnumProperty(int property) const = 0;
virtual void SetEnumProperty(int property, int value) = 0;