Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-26 01:51:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed cpplint.py warnings (#215)

Browse Source 
* Fixed cpplint.py [build/include_order] and [build/include_what_you_use] warnings
* Fixed cpplint.py [readability/casting] warnings
* Updated .styleguide format
* Fixed cpplint.py [build/header_guard] warnings
This commit is contained in:
Tyler Veness
2016-09-05 13:55:31 -07:00
committed by Peter Johnson
parent 59ec54887d
commit 05626cfafe
132 changed files with 280 additions and 172 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
wpilibc/shared/src/Commands/CommandGroup.cpp
View File

@@ -181,7 +181,7 @@ void CommandGroup::_Execute() {
m_currentCommandIndex = 0;
}
while ((unsigned)m_currentCommandIndex < m_commands.size()) {
while (static_cast<size_t>(m_currentCommandIndex) < m_commands.size()) {
if (cmd != nullptr) {
if (entry.IsTimedOut()) cmd->_Cancel();
@@ -243,7 +243,7 @@ void CommandGroup::_End() {
// Theoretically, we don't have to check this, but we do if teams override the
// IsFinished method
if (m_currentCommandIndex != -1 &&
(unsigned)m_currentCommandIndex < m_commands.size()) {
static_cast<size_t>(m_currentCommandIndex) < m_commands.size()) {
Command* cmd = m_commands[m_currentCommandIndex].m_command;
cmd->_Cancel();
cmd->Removed();
@@ -273,7 +273,7 @@ void CommandGroup::End() {}
void CommandGroup::Interrupted() {}
bool CommandGroup::IsFinished() {
return (unsigned)m_currentCommandIndex >= m_commands.size() &&
return static_cast<size_t>(m_currentCommandIndex) >= m_commands.size() &&
m_children.empty();
}
@@ -281,7 +281,7 @@ bool CommandGroup::IsInterruptible() const {
if (!Command::IsInterruptible()) return false;
if (m_currentCommandIndex != -1 &&
(unsigned)m_currentCommandIndex < m_commands.size()) {
static_cast<size_t>(m_currentCommandIndex) < m_commands.size()) {
Command* cmd = m_commands[m_currentCommandIndex].m_command;
if (!cmd->IsInterruptible()) return false;
}