Fixed cpplint.py warnings (#215)

* Fixed cpplint.py [build/include_order] and [build/include_what_you_use] warnings
* Fixed cpplint.py [readability/casting] warnings
* Updated .styleguide format
* Fixed cpplint.py [build/header_guard] warnings

wpilibc/sim/include/AnalogGyro.h

@@ -7,11 +7,11 @@
 
 #pragma once
 
+#include <memory>
+
 #include "GyroBase.h"
 #include "simulation/SimGyro.h"
 
-#include <memory>
-
 class AnalogInput;
 class AnalogModule;
 

wpilibc/sim/include/AnalogInput.h

@@ -7,13 +7,14 @@
 
 #pragma once
 
+#include <memory>
+#include <string>
+
 #include "LiveWindow/LiveWindowSendable.h"
 #include "PIDSource.h"
 #include "SensorBase.h"
 #include "simulation/SimFloatInput.h"
 
-#include <memory>
-
 /**
  * Analog input class.
  *

wpilibc/sim/include/AnalogPotentiometer.h

@@ -7,12 +7,13 @@
 
 #pragma once
 
+#include <memory>
+#include <string>
+
 #include "AnalogInput.h"
 #include "LiveWindow/LiveWindowSendable.h"
 #include "interfaces/Potentiometer.h"
 
-#include <memory>
-
 /**
  * Class for reading analog potentiometers. Analog potentiometers read
  * in an analog voltage that corresponds to a position. Usually the

wpilibc/sim/include/Counter.h

@@ -7,12 +7,13 @@
 
 #pragma once
 
+#include <memory>
+#include <string>
+
 #include "CounterBase.h"
 #include "LiveWindow/LiveWindowSendable.h"
 #include "SensorBase.h"
 
-#include <memory>
-
 /**
  * Class for counting the number of ticks on a digital input channel.
  *

wpilibc/sim/include/DigitalInput.h

@@ -7,11 +7,12 @@
 
 #pragma once
 
+#include <memory>
+#include <string>
+
 #include "LiveWindow/LiveWindowSendable.h"
 #include "simulation/SimDigitalInput.h"
 
-#include <memory>
-
 /**
  * Class to read a digital input.
  *

wpilibc/sim/include/DoubleSolenoid.h

@@ -7,12 +7,13 @@
 
 #pragma once
 
+#include <memory>
+#include <string>
+
 #include "LiveWindow/LiveWindowSendable.h"
 #include "simulation/SimContinuousOutput.h"
 #include "tables/ITableListener.h"
 
-#include <memory>
-
 /**
  * DoubleSolenoid class for running 2 channels of high voltage Digital Output
  * (PCM).

wpilibc/sim/include/DriverStation.h

@@ -7,8 +7,6 @@
 
 #pragma once
 
-#include "simulation/gz_msgs/msgs.h"
-
 #ifdef _WIN32
 // Ensure that Winsock2.h is included before Windows.h, which can get
 // pulled in by anybody (e.g., Boost).
@@ -16,10 +14,14 @@
 #endif
 
 #include <condition_variable>
-#include <gazebo/transport/transport.hh>
 #include <mutex>
+#include <string>
+
+#include <gazebo/transport/transport.hh>
+
 #include "RobotState.h"
 #include "SensorBase.h"
+#include "simulation/gz_msgs/msgs.h"
 
 struct HALCommonControlData;
 class AnalogInput;

wpilibc/sim/include/Encoder.h

@@ -10,6 +10,7 @@
 #include <stdint.h>
 
 #include <memory>
+#include <string>
 
 #include "CounterBase.h"
 #include "LiveWindow/LiveWindowSendable.h"

wpilibc/sim/include/MotorSafetyHelper.h

@@ -7,11 +7,11 @@
 
 #pragma once
 
+#include <set>
+
 #include "ErrorBase.h"
 #include "HAL/cpp/priority_mutex.h"
 
-#include <set>
-
 class MotorSafety;
 
 class MotorSafetyHelper : public ErrorBase {

wpilibc/sim/include/Notifier.h

@@ -11,6 +11,7 @@
 #include <functional>
 #include <list>
 #include <thread>
+#include <utility>
 
 #include "ErrorBase.h"
 #include "HAL/cpp/priority_mutex.h"

wpilibc/sim/include/PWM.h

@@ -7,13 +7,14 @@
 
 #pragma once
 
+#include <memory>
+#include <string>
+
 #include "LiveWindow/LiveWindowSendable.h"
 #include "SensorBase.h"
 #include "simulation/SimContinuousOutput.h"
 #include "tables/ITableListener.h"
 
-#include <memory>
-
 /**
  * Class implements the PWM generation in the FPGA.
  *

wpilibc/sim/include/Relay.h

@@ -7,6 +7,9 @@
 
 #pragma once
 
+#include <memory>
+#include <string>
+
 #include "LiveWindow/LiveWindowSendable.h"
 #include "MotorSafety.h"
 #include "SensorBase.h"
@@ -14,8 +17,6 @@
 #include "tables/ITable.h"
 #include "tables/ITableListener.h"
 
-#include <memory>
-
 class MotorSafetyHelper;
 class DigitalModule;
 

wpilibc/sim/include/Solenoid.h

@@ -7,12 +7,13 @@
 
 #pragma once
 
+#include <memory>
+#include <string>
+
 #include "LiveWindow/LiveWindowSendable.h"
 #include "simulation/SimContinuousOutput.h"
 #include "tables/ITableListener.h"
 
-#include <memory>
-
 /**
  * Solenoid class for running high voltage Digital Output (PCM).
  *

wpilibc/sim/include/simulation/MainNode.h

@@ -7,8 +7,11 @@
 
 #pragma once
 
+#include <string>
+
 #include <gazebo/gazebo_client.hh>
 #include <gazebo/transport/transport.hh>
+
 #include "simulation/gz_msgs/msgs.h"
 
 using namespace gazebo;

wpilibc/sim/include/simulation/SimContinuousOutput.h

@@ -13,7 +13,10 @@
 #include <Winsock2.h>
 #endif
 
+#include <string>
+
 #include <gazebo/transport/transport.hh>
+
 #include "SpeedController.h"
 
 using namespace gazebo;

wpilibc/sim/include/simulation/SimDigitalInput.h

@@ -7,7 +7,10 @@
 
 #pragma once
 
+#include <string>
+
 #include <gazebo/transport/transport.hh>
+
 #include "simulation/gz_msgs/msgs.h"
 
 using namespace gazebo;

wpilibc/sim/include/simulation/SimEncoder.h

@@ -7,8 +7,11 @@
 
 #pragma once
 
+#include <string>
+
 #include <gazebo/common/Time.hh>
 #include <gazebo/transport/transport.hh>
+
 #include "simulation/gz_msgs/msgs.h"
 
 using namespace gazebo;

wpilibc/sim/include/simulation/SimFloatInput.h

@@ -7,7 +7,10 @@
 
 #pragma once
 
+#include <string>
+
 #include <gazebo/transport/transport.hh>
+
 #include "simulation/gz_msgs/msgs.h"
 
 using namespace gazebo;

wpilibc/sim/include/simulation/SimGyro.h

@@ -7,7 +7,10 @@
 
 #pragma once
 
+#include <string>
+
 #include <gazebo/transport/transport.hh>
+
 #include "simulation/gz_msgs/msgs.h"
 
 using namespace gazebo;

wpilibc/sim/include/simulation/simTime.h

@@ -13,11 +13,11 @@
 #include <Winsock2.h>
 #endif
 
-#include "simulation/SimFloatInput.h"
-
 #include <condition_variable>
 #include <mutex>
 
+#include "simulation/SimFloatInput.h"
+
 namespace wpilib {
 namespace internal {
 extern double simTime;