Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-20 00:51:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

[hal] Ensure HAL status variables are initialized to zero (#3421)

Browse Source 
HAL functions don't set the status variable on success, so it's possible
to use the status variable in an uninitialized state.
This commit is contained in:
Tyler Veness
2021-06-08 21:18:59 -07:00
committed by GitHub
parent d068fb321f
commit 0773f4033e
13 changed files with 13 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
hal/src/test/native/cpp/mockdata/DIODataTests.cpp
View File

@@ -28,12 +28,11 @@ TEST(DigitalIoSimTests, TestDigitalIoInitialization) {
false);
ASSERT_TRUE(0 != callbackId);
int32_t status;
int32_t status = 0;
HAL_PortHandle portHandle;
HAL_DigitalHandle digitalIoHandle;
// Use out of range index
status = 0;
portHandle = 8000;
gTestDigitalIoCallbackName = "Unset";
digitalIoHandle = HAL_InitializeDIOPort(portHandle, true, nullptr, &status);