Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-19 00:41:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

[sysid] Fix test duration slider responsiveness (#6216)

Browse Source
This commit is contained in:
Eli Barnett
2024-01-13 02:05:46 -05:00
committed by GitHub
parent 84e3a22baa
commit 077c8f4092
2 changed files with 16 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
sysid/src/main/native/cpp/analysis/FilteringUtils.cpp
View File

@@ -158,18 +158,22 @@ sysid::TrimStepVoltageData(std::vector<PreparedData>* data,
minStepTime = std::min(data->at(0).timestamp - firstTimestamp, minStepTime);
// Find maximum speed reached
const auto maxSpeed =
GetMaxSpeed(*data, [](auto&& pt) { return pt.velocity; });
// Find place where 90% of maximum speed exceeded
auto endIt =
std::find_if(data->begin(), data->end(), [&](const PreparedData& entry) {
return std::abs(entry.velocity) > maxSpeed * 0.9;
});
// If step test duration not yet specified, calculate default
if (settings->stepTestDuration == 0_s) {
// Find maximum speed reached
const auto maxSpeed =
GetMaxSpeed(*data, [](auto&& pt) { return pt.velocity; });
// Find place where 90% of maximum speed exceeded
auto endIt = std::find_if(
data->begin(), data->end(), [&](const PreparedData& entry) {
return std::abs(entry.velocity) > maxSpeed * 0.9;
});
if (endIt != data->end()) {
settings->stepTestDuration = std::min(
endIt->timestamp - data->front().timestamp + minStepTime, maxStepTime);
if (endIt != data->end()) {
settings->stepTestDuration =
std::min(endIt->timestamp - data->front().timestamp + minStepTime,
maxStepTime);
}
}
// Find first entry greater than the step test duration