Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-26 01:51:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixes warnings thrown by cpplint.py (#154)

Browse Source 
* Fixed cpplint.py [runtime/int] warnings

* Fixed cpplint.py [readability/casting] warnings

* Fixed cpplint.py [readability/namespace] warnings

* Fixed cpplint.py [readability/braces] warnings

* Fixed cpplint.py [whitespace/braces] warnings

* Fixed cpplint.py [runtime/explicit] warnings

* Fixed cpplint.py [runtime/printf] warnings

* Fixed cpplint.py [readability/inheritance] warnings

* Fixed cpplint.py [whitespace/tab] warnings

* Fixed cpplint.py [build/storage_class] warnings

* Fixed cpplint.py [readability/multiline_comment] warnings

* Fixed cpplint.py [whitespace/semicolon] warnings

* Fixed cpplint.py [readability/check] warnings

* Fixed cpplint.py [runtime/arrays] warnings

* Ran format.py
This commit is contained in:
Tyler Veness
2016-07-10 17:47:44 -07:00
committed by Peter Johnson
parent e44a6e227a
commit 0cb288ffba
141 changed files with 670 additions and 626 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
wpilibc/shared/include/Commands/Command.h
View File

@@ -52,8 +52,8 @@ class Command : public ErrorBase, public NamedSendable, public ITableListener {
public:
Command();
Command(const std::string& name);
Command(double timeout);
explicit Command(const std::string& name);
explicit Command(double timeout);
Command(const std::string& name, double timeout);
virtual ~Command();
double TimeSinceInitialized() const;
@@ -167,12 +167,12 @@ class Command : public ErrorBase, public NamedSendable, public ITableListener {
static int m_commandCounter;
public:
virtual std::string GetName() const;
virtual void InitTable(std::shared_ptr<ITable> table);
virtual std::shared_ptr<ITable> GetTable() const;
virtual std::string GetSmartDashboardType() const;
virtual void ValueChanged(ITable* source, llvm::StringRef key,
std::shared_ptr<nt::Value> value, bool isNew);
std::string GetName() const override;
void InitTable(std::shared_ptr<ITable> subtable) override;
std::shared_ptr<ITable> GetTable() const override;
std::string GetSmartDashboardType() const override;
void ValueChanged(ITable* source, llvm::StringRef key,
std::shared_ptr<nt::Value> value, bool isNew) override;
protected:
std::shared_ptr<ITable> m_table;

2
wpilibc/shared/include/Commands/CommandGroup.h
View File

@@ -35,7 +35,7 @@
class CommandGroup : public Command {
public:
CommandGroup() = default;
CommandGroup(const std::string& name);
explicit CommandGroup(const std::string& name);
virtual ~CommandGroup() = default;
void AddSequential(Command* command);

4
wpilibc/shared/include/Commands/PIDCommand.h
View File

@@ -51,6 +51,6 @@ class PIDCommand : public Command, public PIDOutput, public PIDSource {
std::shared_ptr<PIDController> m_controller;
public:
virtual void InitTable(std::shared_ptr<ITable> table);
virtual std::string GetSmartDashboardType() const;
void InitTable(std::shared_ptr<ITable> subtable) override;
std::string GetSmartDashboardType() const override;
};

4
wpilibc/shared/include/Commands/PIDSubsystem.h
View File

@@ -66,6 +66,6 @@ class PIDSubsystem : public Subsystem, public PIDOutput, public PIDSource {
std::shared_ptr<PIDController> m_controller;
public:
virtual void InitTable(std::shared_ptr<ITable> table);
virtual std::string GetSmartDashboardType() const;
void InitTable(std::shared_ptr<ITable> subtable) override;
std::string GetSmartDashboardType() const override;
};

2
wpilibc/shared/include/Commands/PrintCommand.h
View File

@@ -12,7 +12,7 @@
class PrintCommand : public Command {
public:
PrintCommand(const std::string& message);
explicit PrintCommand(const std::string& message);
virtual ~PrintCommand() = default;
protected:

2
wpilibc/shared/include/Commands/StartCommand.h
View File

@@ -11,7 +11,7 @@
class StartCommand : public Command {
public:
StartCommand(Command* commandToStart);
explicit StartCommand(Command* commandToStart);
virtual ~StartCommand() = default;
protected:

10
wpilibc/shared/include/Commands/Subsystem.h
View File

@@ -18,7 +18,7 @@ class Subsystem : public ErrorBase, public NamedSendable {
friend class Scheduler;
public:
Subsystem(const std::string& name);
explicit Subsystem(const std::string& name);
virtual ~Subsystem() = default;
void SetDefaultCommand(Command* command);
@@ -37,10 +37,10 @@ class Subsystem : public ErrorBase, public NamedSendable {
bool m_initializedDefaultCommand = false;
public:
virtual std::string GetName() const;
virtual void InitTable(std::shared_ptr<ITable> table);
virtual std::shared_ptr<ITable> GetTable() const;
virtual std::string GetSmartDashboardType() const;
std::string GetName() const override;
void InitTable(std::shared_ptr<ITable> subtable) override;
std::shared_ptr<ITable> GetTable() const override;
std::string GetSmartDashboardType() const override;
protected:
std::shared_ptr<ITable> m_table;

2
wpilibc/shared/include/Commands/WaitCommand.h
View File

@@ -11,7 +11,7 @@
class WaitCommand : public Command {
public:
WaitCommand(double timeout);
explicit WaitCommand(double timeout);
WaitCommand(const std::string& name, double timeout);
virtual ~WaitCommand() = default;

2
wpilibc/shared/include/Commands/WaitForChildren.h
View File

@@ -11,7 +11,7 @@
class WaitForChildren : public Command {
public:
WaitForChildren(double timeout);
explicit WaitForChildren(double timeout);
WaitForChildren(const std::string& name, double timeout);
virtual ~WaitForChildren() = default;

2
wpilibc/shared/include/Commands/WaitUntilCommand.h
View File

@@ -11,7 +11,7 @@
class WaitUntilCommand : public Command {
public:
WaitUntilCommand(double time);
explicit WaitUntilCommand(double time);
WaitUntilCommand(const std::string& name, double time);
virtual ~WaitUntilCommand() = default;