Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-28 02:11:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

SpeedControllerGroup: Call set() from pidWrite()

Browse Source 
This means pidWrite() now takes m_isInverted into account.
Fixes #887.
This commit is contained in:
Nic Hodlofski
2018-01-18 22:03:13 -06:00
committed by Peter Johnson
parent 54a0a7654a
commit 0e8ff4663d
2 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
wpilibc/src/main/native/cpp/SpeedControllerGroup.cpp
View File

@@ -42,11 +42,7 @@ void SpeedControllerGroup::StopMotor() {
}
}
void SpeedControllerGroup::PIDWrite(double output) {
for (auto speedController : m_speedControllers) {
speedController.get().PIDWrite(output);
}
}
void SpeedControllerGroup::PIDWrite(double output) { Set(output); }
void SpeedControllerGroup::InitSendable(SendableBuilder& builder) {
builder.SetSmartDashboardType("Speed Controller");

4
wpilibj/src/main/java/edu/wpi/first/wpilibj/SpeedControllerGroup.java
View File

@@ -76,9 +76,7 @@ public class SpeedControllerGroup extends SendableBase implements SpeedControlle
@Override
public void pidWrite(double output) {
for (SpeedController speedController : m_speedControllers) {
speedController.pidWrite(output);
}
set(output);
}
@Override