Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-07-06 03:31:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix many errorprone warnings (#1247)

Browse Source 
This fixes two real bugs:
- TimedRobot had a m_period that was hiding the IterativeRobotBase m_period
  and was not getting initialized.
- PDPSim was swapping two parameters to getCurrent()
This commit is contained in:
Peter Johnson
2018-07-29 16:47:22 -07:00
committed by GitHub
parent 6db5f80430
commit 0e9172f9a7
28 changed files with 50 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ntcore/src/main/java/edu/wpi/first/networktables/NetworkTableValue.java
View File

@@ -258,7 +258,7 @@ public final class NetworkTableValue {
* @return The entry value
*/
public static NetworkTableValue makeBoolean(boolean value) {
return new NetworkTableValue(NetworkTableType.kBoolean, new Boolean(value));
return new NetworkTableValue(NetworkTableType.kBoolean, Boolean.valueOf(value));
}
/**
@@ -269,7 +269,7 @@ public final class NetworkTableValue {
* @return The entry value
*/
public static NetworkTableValue makeBoolean(boolean value, long time) {
return new NetworkTableValue(NetworkTableType.kBoolean, new Boolean(value), time);
return new NetworkTableValue(NetworkTableType.kBoolean, Boolean.valueOf(value), time);
}
/**
@@ -279,7 +279,7 @@ public final class NetworkTableValue {
* @return The entry value
*/
public static NetworkTableValue makeDouble(double value) {
return new NetworkTableValue(NetworkTableType.kDouble, new Double(value));
return new NetworkTableValue(NetworkTableType.kDouble, Double.valueOf(value));
}
/**
@@ -290,7 +290,7 @@ public final class NetworkTableValue {
* @return The entry value
*/
public static NetworkTableValue makeDouble(double value, long time) {
return new NetworkTableValue(NetworkTableType.kDouble, new Double(value), time);
return new NetworkTableValue(NetworkTableType.kDouble, Double.valueOf(value), time);
}
/**

6
ntcore/src/main/java/edu/wpi/first/wpilibj/networktables/NetworkTable.java
View File

@@ -483,7 +483,7 @@ public class NetworkTable implements ITable, IRemote {
public int uid;
}
private class OldTableListenerAdapter extends ListenerBase implements Consumer<EntryNotification> {
private static class OldTableListenerAdapter extends ListenerBase implements Consumer<EntryNotification> {
private final int prefixLen;
private final ITable targetSource;
private final ITableListener targetListener;
@@ -539,7 +539,7 @@ public class NetworkTable implements ITable, IRemote {
addTableListenerEx(key, listener, flags);
}
private class OldKeyListenerAdapter extends ListenerBase implements Consumer<EntryNotification> {
private static class OldKeyListenerAdapter extends ListenerBase implements Consumer<EntryNotification> {
private final String relativeKey;
private final ITable targetSource;
private final ITableListener targetListener;
@@ -587,7 +587,7 @@ public class NetworkTable implements ITable, IRemote {
addSubTableListener(listener, false);
}
private class OldSubListenerAdapter extends ListenerBase implements Consumer<EntryNotification> {
private static class OldSubListenerAdapter extends ListenerBase implements Consumer<EntryNotification> {
private final int prefixLen;
private final ITable targetSource;
private final ITableListener targetListener;