Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-07-03 03:01:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Notifier: Take Impl rather than handle in notification functions.

Browse Source 
Also take CS_EventKind rather than RawEvent::Kind.

Still provide the handle methods for the basic events (this is particularly
useful for create and destroy events).

This makes these functions easier to use from within the implementation.
This commit is contained in:
Peter Johnson
2016-11-18 07:49:33 -08:00
parent bae2037086
commit 154ae5dcbf
2 changed files with 43 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
src/Notifier.cpp
View File

@@ -11,6 +11,8 @@
#include <vector>
#include "Handle.h"
#include "SinkImpl.h"
#include "SourceImpl.h"
using namespace cs;
@@ -151,37 +153,54 @@ void Notifier::RemoveListener(int uid) {
}
void Notifier::NotifySource(llvm::StringRef name, CS_Source source,
RawEvent::Kind kind) {
CS_EventKind kind) {
auto thr = m_owner.GetThread();
if (!thr) return;
thr->m_notifications.emplace(name, source, kind);
thr->m_notifications.emplace(name, source, static_cast<RawEvent::Kind>(kind));
thr->m_cond.notify_one();
}
void Notifier::NotifySourceVideoMode(llvm::StringRef name, CS_Source source,
void Notifier::NotifySource(const SourceImpl& source, CS_EventKind kind) {
auto handleData = Sources::GetInstance().Find(source);
NotifySource(source.GetName(), handleData.first, kind);
}
void Notifier::NotifySourceVideoMode(const SourceImpl& source,
const VideoMode& mode) {
auto thr = m_owner.GetThread();
if (!thr) return;
thr->m_notifications.emplace(name, source, mode);
auto handleData = Sources::GetInstance().Find(source);
thr->m_notifications.emplace(source.GetName(), handleData.first, mode);
thr->m_cond.notify_one();
}
void Notifier::NotifySourceProperty(llvm::StringRef name, CS_Source source,
RawEvent::Kind kind, int property,
CS_PropertyKind propertyKind, int value,
llvm::StringRef valueStr) {
void Notifier::NotifySourceProperty(const SourceImpl& source, CS_EventKind kind,
int property, CS_PropertyKind propertyKind,
int value, llvm::StringRef valueStr) {
auto thr = m_owner.GetThread();
if (!thr) return;
thr->m_notifications.emplace(name, source, kind,
Handle{source, property, Handle::kProperty},
propertyKind, value, valueStr);
auto handleData = Sources::GetInstance().Find(source);
thr->m_notifications.emplace(
source.GetName(), handleData.first, static_cast<RawEvent::Kind>(kind),
Handle{handleData.first, property, Handle::kProperty}, propertyKind,
value, valueStr);
thr->m_cond.notify_one();
}
void Notifier::NotifySink(llvm::StringRef name, CS_Sink sink,
RawEvent::Kind kind) {
CS_EventKind kind) {
auto thr = m_owner.GetThread();
if (!thr) return;
thr->m_notifications.emplace(name, sink, kind);
thr->m_notifications.emplace(name, sink, static_cast<RawEvent::Kind>(kind));
thr->m_cond.notify_one();
}
void Notifier::NotifySink(const SinkImpl& sink, CS_EventKind kind) {
auto handleData = Sinks::GetInstance().Find(sink);
NotifySink(sink.GetName(), handleData.first, kind);
}

20
src/Notifier.h
View File

@@ -16,6 +16,9 @@
namespace cs {
class SinkImpl;
class SourceImpl;
class Notifier {
friend class NotifierTest;
@@ -39,15 +42,14 @@ class Notifier {
void RemoveListener(int uid);
// Notification events
void NotifySource(llvm::StringRef name, CS_Source source,
RawEvent::Kind kind);
void NotifySourceVideoMode(llvm::StringRef name, CS_Source source,
const VideoMode& mode);
void NotifySourceProperty(llvm::StringRef name, CS_Source source,
RawEvent::Kind kind, int property,
CS_PropertyKind propertyKind, int value,
llvm::StringRef valueStr);
void NotifySink(llvm::StringRef name, CS_Sink sink, RawEvent::Kind kind);
void NotifySource(llvm::StringRef name, CS_Source source, CS_EventKind kind);
void NotifySource(const SourceImpl& source, CS_EventKind kind);
void NotifySourceVideoMode(const SourceImpl& source, const VideoMode& mode);
void NotifySourceProperty(const SourceImpl& source, CS_EventKind kind,
int property, CS_PropertyKind propertyKind,
int value, llvm::StringRef valueStr);
void NotifySink(llvm::StringRef name, CS_Sink sink, CS_EventKind kind);
void NotifySink(const SinkImpl& sink, CS_EventKind kind);
private:
Notifier();