Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-19 00:41:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace C++ unit .to<double>() with .value() (#6317)

Browse Source 
The latter is shorter and is what we use everywhere else.
This commit is contained in:
Tyler Veness
2024-01-27 07:58:25 -08:00
committed by GitHub
parent bbb230491a
commit 177132fa2a
3 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
wpilibc/src/main/native/cpp/DigitalOutput.cpp
View File

@@ -78,7 +78,7 @@ int DigitalOutput::GetChannel() const {
void DigitalOutput::Pulse(units::second_t pulseLength) {
int32_t status = 0;
HAL_Pulse(m_handle, pulseLength.to<double>(), &status);
HAL_Pulse(m_handle, pulseLength.value(), &status);
FRC_CheckErrorStatus(status, "Channel {}", m_channel);
}

12
wpilibc/src/main/native/cpp/counter/Tachometer.cpp
View File

@@ -44,7 +44,7 @@ Tachometer::~Tachometer() {
units::hertz_t Tachometer::GetFrequency() const {
auto period = GetPeriod();
if (period.to<double>() == 0) {
if (period.value() == 0) {
return units::hertz_t{0.0};
}
return 1 / period;
@@ -66,7 +66,7 @@ void Tachometer::SetEdgesPerRevolution(int edges) {
units::turns_per_second_t Tachometer::GetRevolutionsPerSecond() const {
auto period = GetPeriod();
if (period.to<double>() == 0) {
if (period.value() == 0) {
return units::turns_per_second_t{0.0};
}
int edgesPerRevolution = GetEdgesPerRevolution();
@@ -74,7 +74,7 @@ units::turns_per_second_t Tachometer::GetRevolutionsPerSecond() const {
return units::turns_per_second_t{0.0};
}
auto rotationHz = ((1.0 / edgesPerRevolution) / period);
return units::turns_per_second_t{rotationHz.to<double>()};
return units::turns_per_second_t{rotationHz.value()};
}
units::revolutions_per_minute_t Tachometer::GetRevolutionsPerMinute() const {
@@ -103,7 +103,7 @@ void Tachometer::SetSamplesToAverage(int samples) {
void Tachometer::SetMaxPeriod(units::second_t maxPeriod) {
int32_t status = 0;
HAL_SetCounterMaxPeriod(m_handle, maxPeriod.to<double>(), &status);
HAL_SetCounterMaxPeriod(m_handle, maxPeriod.value(), &status);
FRC_CheckErrorStatus(status, "Channel {}", m_source->GetChannel());
}
@@ -116,7 +116,7 @@ void Tachometer::SetUpdateWhenEmpty(bool updateWhenEmpty) {
void Tachometer::InitSendable(wpi::SendableBuilder& builder) {
builder.SetSmartDashboardType("Tachometer");
builder.AddDoubleProperty(
"RPS", [&] { return GetRevolutionsPerSecond().to<double>(); }, nullptr);
"RPS", [&] { return GetRevolutionsPerSecond().value(); }, nullptr);
builder.AddDoubleProperty(
"RPM", [&] { return GetRevolutionsPerMinute().to<double>(); }, nullptr);
"RPM", [&] { return GetRevolutionsPerMinute().value(); }, nullptr);
}