Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-19 00:41:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

[hal] Remove useless usage reporting return (#8625)

Browse Source 
The value is not used anywhere and it also just returns 0 (was a value
from Netcomm in pre-2027).
This commit is contained in:
Gold856
2026-02-20 18:28:57 -05:00
committed by GitHub
parent 0c44e63465
commit 1806cd2d78
7 changed files with 24 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
hal/src/main/native/cpp/UsageReporting.cpp
View File

@@ -6,7 +6,7 @@
#include <fmt/format.h>
int32_t HAL_ReportUsage(std::string_view resource, int instanceNumber,
std::string_view data) {
return HAL_ReportUsage(fmt::format("{}[{}]", resource, instanceNumber), data);
void HAL_ReportUsage(std::string_view resource, int instanceNumber,
std::string_view data) {
HAL_ReportUsage(fmt::format("{}[{}]", resource, instanceNumber), data);
}

6
hal/src/main/native/cpp/jni/UsageReportingJNI.cpp
View File

@@ -18,9 +18,9 @@ extern "C" {
/*
* Class: org_wpilib_hardware_hal_UsageReportingJNI
* Method: report
* Signature: (Ljava/lang/String;Ljava/lang/String;)I
* Signature: (Ljava/lang/String;Ljava/lang/String;)V
*/
JNIEXPORT jint JNICALL
JNIEXPORT void JNICALL
Java_org_wpilib_hardware_hal_UsageReportingJNI_report
(JNIEnv* env, jclass, jstring resource, jstring data)
{
@@ -28,7 +28,7 @@ Java_org_wpilib_hardware_hal_UsageReportingJNI_report
JStringRef dataStr{env, data};
WPI_String resourceWpiStr = wpi::util::make_string(resourceStr);
WPI_String dataWpiStr = wpi::util::make_string(dataStr);
return HAL_ReportUsage(&resourceWpiStr, &dataWpiStr);
HAL_ReportUsage(&resourceWpiStr, &dataWpiStr);
}
} // extern "C"