From 184fae4ba5a4e2f665f2b0147033d5abcfe5730e Mon Sep 17 00:00:00 2001 From: Peter Johnson Date: Sat, 21 Mar 2020 10:36:31 -0700 Subject: [PATCH] DutyCycleEncoder: Set ownsDutyCycle for channel constructor (#2436) Also close dutyCycle before closing digitalInput. --- .../main/java/edu/wpi/first/wpilibj/DutyCycleEncoder.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/DutyCycleEncoder.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/DutyCycleEncoder.java index 1df9369bc0..07b2878908 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/DutyCycleEncoder.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/DutyCycleEncoder.java @@ -41,6 +41,7 @@ public class DutyCycleEncoder implements Sendable, AutoCloseable { */ public DutyCycleEncoder(int channel) { m_digitalInput = new DigitalInput(channel); + m_ownsDutyCycle = true; m_dutyCycle = new DutyCycle(m_digitalInput); init(); } @@ -218,12 +219,12 @@ public class DutyCycleEncoder implements Sendable, AutoCloseable { if (m_analogTrigger != null) { m_analogTrigger.close(); } - if (m_digitalInput != null) { - m_digitalInput.close(); - } if (m_ownsDutyCycle) { m_dutyCycle.close(); } + if (m_digitalInput != null) { + m_digitalInput.close(); + } if (m_simDevice != null) { m_simDevice.close(); }