Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-20 00:51:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

cscore: Use Twine instead of StringRef in API (#1244)

Browse Source
This commit is contained in:
Peter Johnson
2018-07-29 12:53:41 -07:00
committed by GitHub
parent 97a8f8f47b
commit 195e101816
35 changed files with 365 additions and 350 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
cscore/src/main/native/cpp/PropertyImpl.cpp
View File

@@ -9,18 +9,18 @@
using namespace cs;
PropertyImpl::PropertyImpl(wpi::StringRef name_) : name{name_} {}
PropertyImpl::PropertyImpl(wpi::StringRef name_, CS_PropertyKind kind_,
PropertyImpl::PropertyImpl(const wpi::Twine& name_) : name{name_.str()} {}
PropertyImpl::PropertyImpl(const wpi::Twine& name_, CS_PropertyKind kind_,
int step_, int defaultValue_, int value_)
: name{name_},
: name{name_.str()},
propKind{kind_},
step{step_},
defaultValue{defaultValue_},
value{value_} {}
PropertyImpl::PropertyImpl(wpi::StringRef name_, CS_PropertyKind kind_,
PropertyImpl::PropertyImpl(const wpi::Twine& name_, CS_PropertyKind kind_,
int minimum_, int maximum_, int step_,
int defaultValue_, int value_)
: name{name_},
: name{name_.str()},
propKind{kind_},
hasMinimum{true},
hasMaximum{true},
@@ -43,10 +43,11 @@ void PropertyImpl::SetValue(int v) {
if (!wasValueSet || value != oldValue) changed();
}
void PropertyImpl::SetValue(wpi::StringRef v) {
void PropertyImpl::SetValue(const wpi::Twine& v) {
bool valueChanged = false;
if (valueStr != v) {
valueStr = v;
std::string vStr = v.str();
if (valueStr != vStr) {
valueStr = vStr;
valueChanged = true;
}
bool wasValueSet = valueSet;