diff --git a/cameraserver/src/main/java/edu/wpi/first/cameraserver/CameraServer.java b/cameraserver/src/main/java/edu/wpi/first/cameraserver/CameraServer.java index 12dfbf66a1..5597f8002e 100644 --- a/cameraserver/src/main/java/edu/wpi/first/cameraserver/CameraServer.java +++ b/cameraserver/src/main/java/edu/wpi/first/cameraserver/CameraServer.java @@ -27,6 +27,7 @@ import edu.wpi.first.networktables.StringArrayTopic; import edu.wpi.first.networktables.StringEntry; import edu.wpi.first.networktables.StringPublisher; import edu.wpi.first.util.PixelFormat; +import java.lang.ref.Reference; import java.util.ArrayList; import java.util.Arrays; import java.util.HashMap; @@ -140,6 +141,7 @@ public final class CameraServer { if (m_choicesPublisher != null) { m_choicesPublisher.close(); } + Reference.reachabilityFence(m_videoListener); } BooleanEntry m_booleanValueEntry; @@ -223,7 +225,7 @@ public final class CameraServer { // - "PropertyInfo/{Property}" - Property supporting information // Listener for video events - @SuppressWarnings({"PMD.UnusedPrivateField", "PMD.AvoidCatchingGenericException"}) + @SuppressWarnings("PMD.AvoidCatchingGenericException") private static final VideoListener m_videoListener = new VideoListener( event -> { diff --git a/fieldImages/src/main/java/edu/wpi/fields/FieldConfig.java b/fieldImages/src/main/java/edu/wpi/fields/FieldConfig.java index f33ddca6dc..d8752c64b9 100644 --- a/fieldImages/src/main/java/edu/wpi/fields/FieldConfig.java +++ b/fieldImages/src/main/java/edu/wpi/fields/FieldConfig.java @@ -40,12 +40,10 @@ public class FieldConfig { public FieldConfig() {} - @SuppressWarnings("deprecation") public URL getImageUrl() { return getClass().getResource(Fields.kBaseResourceDir + m_fieldImage); } - @SuppressWarnings("deprecation") public InputStream getImageAsStream() { return getClass().getResourceAsStream(Fields.kBaseResourceDir + m_fieldImage); } diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADXL345_I2C.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADXL345_I2C.java index 4f6803d0b8..357618b7f4 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADXL345_I2C.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADXL345_I2C.java @@ -25,7 +25,7 @@ import java.nio.ByteOrder; * href="https://docs.wpilib.org/en/stable/docs/yearly-overview/known-issues.html#onboard-i2c-causing-system-lockups"> * WPILib Known Issues page for details. */ -@SuppressWarnings({"TypeName", "PMD.UnusedPrivateField"}) +@SuppressWarnings("TypeName") public class ADXL345_I2C implements NTSendable, AutoCloseable { /** Default I2C device address. */ public static final byte kAddress = 0x1D; @@ -34,16 +34,17 @@ public class ADXL345_I2C implements NTSendable, AutoCloseable { private static final byte kDataFormatRegister = 0x31; private static final byte kDataRegister = 0x32; private static final double kGsPerLSB = 0.00390625; - private static final byte kPowerCtl_Link = 0x20; - private static final byte kPowerCtl_AutoSleep = 0x10; + // private static final byte kPowerCtl_Link = 0x20; + // private static final byte kPowerCtl_AutoSleep = 0x10; private static final byte kPowerCtl_Measure = 0x08; - private static final byte kPowerCtl_Sleep = 0x04; + // private static final byte kPowerCtl_Sleep = 0x04; - private static final byte kDataFormat_SelfTest = (byte) 0x80; - private static final byte kDataFormat_SPI = 0x40; - private static final byte kDataFormat_IntInvert = 0x20; + // private static final byte kDataFormat_SelfTest = (byte) 0x80; + // private static final byte kDataFormat_SPI = 0x40; + // private static final byte kDataFormat_IntInvert = 0x20; private static final byte kDataFormat_FullRes = 0x08; - private static final byte kDataFormat_Justify = 0x04; + + // private static final byte kDataFormat_Justify = 0x04; /** Accelerometer range. */ public enum Range { diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADXL345_SPI.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADXL345_SPI.java index 4c8435a00b..29a20cbd5c 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADXL345_SPI.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADXL345_SPI.java @@ -19,7 +19,7 @@ import java.nio.ByteBuffer; import java.nio.ByteOrder; /** ADXL345 SPI Accelerometer. */ -@SuppressWarnings({"TypeName", "PMD.UnusedPrivateField"}) +@SuppressWarnings("TypeName") public class ADXL345_SPI implements NTSendable, AutoCloseable { private static final int kPowerCtlRegister = 0x2D; private static final int kDataFormatRegister = 0x31; @@ -29,16 +29,17 @@ public class ADXL345_SPI implements NTSendable, AutoCloseable { private static final int kAddress_Read = 0x80; private static final int kAddress_MultiByte = 0x40; - private static final int kPowerCtl_Link = 0x20; - private static final int kPowerCtl_AutoSleep = 0x10; + // private static final int kPowerCtl_Link = 0x20; + // private static final int kPowerCtl_AutoSleep = 0x10; private static final int kPowerCtl_Measure = 0x08; - private static final int kPowerCtl_Sleep = 0x04; + // private static final int kPowerCtl_Sleep = 0x04; - private static final int kDataFormat_SelfTest = 0x80; - private static final int kDataFormat_SPI = 0x40; - private static final int kDataFormat_IntInvert = 0x20; + // private static final int kDataFormat_SelfTest = 0x80; + // private static final int kDataFormat_SPI = 0x40; + // private static final int kDataFormat_IntInvert = 0x20; private static final int kDataFormat_FullRes = 0x08; - private static final int kDataFormat_Justify = 0x04; + + // private static final int kDataFormat_Justify = 0x04; /** Accelerometer range. */ public enum Range { diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADXL362.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADXL362.java index c3de6dd704..b00ea2b8f6 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADXL362.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADXL362.java @@ -38,8 +38,8 @@ public class ADXL362 implements NTSendable, AutoCloseable { private static final byte kPowerCtl_UltraLowNoise = 0x20; - @SuppressWarnings("PMD.UnusedPrivateField") - private static final byte kPowerCtl_AutoSleep = 0x04; + // @SuppressWarnings("PMD.UnusedPrivateField") + // private static final byte kPowerCtl_AutoSleep = 0x04; private static final byte kPowerCtl_Measure = 0x02; diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADXRS450_Gyro.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADXRS450_Gyro.java index 799d43202b..d574a24824 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADXRS450_Gyro.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/ADXRS450_Gyro.java @@ -26,21 +26,21 @@ import java.nio.ByteOrder; *

This class is for the digital ADXRS450 gyro sensor that connects via SPI. Only one instance of * an ADXRS Gyro is supported. */ -@SuppressWarnings({"TypeName", "PMD.UnusedPrivateField"}) +@SuppressWarnings("TypeName") public class ADXRS450_Gyro implements Sendable, AutoCloseable { private static final double kSamplePeriod = 0.0005; private static final double kCalibrationSampleTime = 5.0; private static final double kDegreePerSecondPerLSB = 0.0125; - private static final int kRateRegister = 0x00; - private static final int kTemRegister = 0x02; - private static final int kLoCSTRegister = 0x04; - private static final int kHiCSTRegister = 0x06; - private static final int kQuadRegister = 0x08; - private static final int kFaultRegister = 0x0A; + // private static final int kRateRegister = 0x00; + // private static final int kTemRegister = 0x02; + // private static final int kLoCSTRegister = 0x04; + // private static final int kHiCSTRegister = 0x06; + // private static final int kQuadRegister = 0x08; + // private static final int kFaultRegister = 0x0A; private static final int kPIDRegister = 0x0C; - private static final int kSNHighRegister = 0x0E; - private static final int kSNLowRegister = 0x10; + // private static final int kSNHighRegister = 0x0E; + // private static final int kSNLowRegister = 0x10; private SPI m_spi; diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogTrigger.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogTrigger.java index ac25fbbdc2..1d4a404dd9 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogTrigger.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/AnalogTrigger.java @@ -12,6 +12,7 @@ import edu.wpi.first.util.sendable.Sendable; import edu.wpi.first.util.sendable.SendableBuilder; import edu.wpi.first.util.sendable.SendableRegistry; import edu.wpi.first.wpilibj.AnalogTriggerOutput.AnalogTriggerType; +import java.lang.ref.Reference; /** Class for creating and configuring Analog Triggers. */ public class AnalogTrigger implements Sendable, AutoCloseable { @@ -20,7 +21,6 @@ public class AnalogTrigger implements Sendable, AutoCloseable { private AnalogInput m_analogInput; - @SuppressWarnings({"PMD.SingularField", "PMD.UnusedPrivateField"}) private DutyCycle m_dutyCycle; private boolean m_ownsAnalog; @@ -80,6 +80,7 @@ public class AnalogTrigger implements Sendable, AutoCloseable { if (m_ownsAnalog && m_analogInput != null) { m_analogInput.close(); } + Reference.reachabilityFence(m_dutyCycle); } /** diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/DriverStation.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/DriverStation.java index 4ee656b419..cbe4da8ac3 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/DriverStation.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/DriverStation.java @@ -48,6 +48,8 @@ public final class DriverStation { private static class HALJoystickAxesRaw { public int[] m_axes; + + @SuppressWarnings("unused") public int m_count; HALJoystickAxesRaw(int count) { diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Watchdog.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Watchdog.java index 18d4b6463d..e1860e38db 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/Watchdog.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/Watchdog.java @@ -208,6 +208,7 @@ public class Watchdog implements Closeable, Comparable { m_suppressTimeoutMessage = suppress; } + @SuppressWarnings("resource") private static void updateAlarm() { if (m_watchdogs.isEmpty()) { NotifierJNI.cancelNotifierAlarm(m_notifier); diff --git a/wpilibj/src/test/java/edu/wpi/first/wpilibj/drive/DifferentialDriveTest.java b/wpilibj/src/test/java/edu/wpi/first/wpilibj/drive/DifferentialDriveTest.java index 474dc89bb8..0546a4ce89 100644 --- a/wpilibj/src/test/java/edu/wpi/first/wpilibj/drive/DifferentialDriveTest.java +++ b/wpilibj/src/test/java/edu/wpi/first/wpilibj/drive/DifferentialDriveTest.java @@ -9,6 +9,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals; import edu.wpi.first.wpilibj.motorcontrol.MockPWMMotorController; import org.junit.jupiter.api.Test; +@SuppressWarnings("resource") class DifferentialDriveTest { @Test void testArcadeDriveIK() { diff --git a/wpilibj/src/test/java/edu/wpi/first/wpilibj/drive/MecanumDriveTest.java b/wpilibj/src/test/java/edu/wpi/first/wpilibj/drive/MecanumDriveTest.java index a1017d51e9..8be2ccb756 100644 --- a/wpilibj/src/test/java/edu/wpi/first/wpilibj/drive/MecanumDriveTest.java +++ b/wpilibj/src/test/java/edu/wpi/first/wpilibj/drive/MecanumDriveTest.java @@ -10,6 +10,7 @@ import edu.wpi.first.math.geometry.Rotation2d; import edu.wpi.first.wpilibj.motorcontrol.MockPWMMotorController; import org.junit.jupiter.api.Test; +@SuppressWarnings("resource") class MecanumDriveTest { @Test void testCartesianIK() { diff --git a/wpilibj/src/test/java/edu/wpi/first/wpilibj/simulation/ElevatorSimTest.java b/wpilibj/src/test/java/edu/wpi/first/wpilibj/simulation/ElevatorSimTest.java index 336489a334..47eb9ae259 100644 --- a/wpilibj/src/test/java/edu/wpi/first/wpilibj/simulation/ElevatorSimTest.java +++ b/wpilibj/src/test/java/edu/wpi/first/wpilibj/simulation/ElevatorSimTest.java @@ -22,6 +22,7 @@ class ElevatorSimTest { void testStateSpaceSimWithElevator() { RoboRioSim.resetData(); + @SuppressWarnings("resource") var controller = new PIDController(10, 0, 0); var sim = diff --git a/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/test/TestBench.java b/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/test/TestBench.java index 508c432cbf..cba5a35713 100644 --- a/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/test/TestBench.java +++ b/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/test/TestBench.java @@ -52,6 +52,7 @@ public final class TestBench { public static final int DIOCrossConnectA1 = 6; /** The Singleton instance of the Test Bench. */ + @SuppressWarnings("unused") private static TestBench instance = null; /** diff --git a/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/test/TestSuite.java b/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/test/TestSuite.java index befc0668bb..232781013e 100644 --- a/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/test/TestSuite.java +++ b/wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/test/TestSuite.java @@ -50,7 +50,10 @@ public class TestSuite extends AbstractTestSuite { TestBench.out().println("Starting Tests"); } + @SuppressWarnings("unused") private static final Logger WPILIBJ_ROOT_LOGGER = Logger.getLogger("edu.wpi.first.wpilibj"); + + @SuppressWarnings("unused") private static final Logger WPILIBJ_COMMAND_ROOT_LOGGER = Logger.getLogger("edu.wpi.first.wpilibj.command"); diff --git a/wpiutil/src/main/java/edu/wpi/first/util/CircularBuffer.java b/wpiutil/src/main/java/edu/wpi/first/util/CircularBuffer.java index ff68d4d9ac..e99bc2b237 100644 --- a/wpiutil/src/main/java/edu/wpi/first/util/CircularBuffer.java +++ b/wpiutil/src/main/java/edu/wpi/first/util/CircularBuffer.java @@ -53,7 +53,6 @@ public class CircularBuffer { * @throws IndexOutOfBoundsException if the index is out of range (index < 0 || index >= * size()) */ - @SuppressWarnings("unchecked") public T getLast() { // If there are no elements in the buffer, do nothing if (m_length == 0) { @@ -111,7 +110,6 @@ public class CircularBuffer { * @throws IndexOutOfBoundsException if the index is out of range (index < 0 || index >= * size()) */ - @SuppressWarnings("unchecked") public T removeFirst() { // If there are no elements in the buffer, do nothing if (m_length == 0) { @@ -131,7 +129,6 @@ public class CircularBuffer { * @throws IndexOutOfBoundsException if the index is out of range (index < 0 || index >= * size()) */ - @SuppressWarnings("unchecked") public T removeLast() { // If there are no elements in the buffer, do nothing if (m_length == 0) {