From 1ad3b1b333ee7e206c56ed4dc6a57cebc6db1b9a Mon Sep 17 00:00:00 2001 From: Tyler Veness Date: Sun, 19 Dec 2021 16:46:12 -0800 Subject: [PATCH] [hal] Don't copy byte to where null terminator goes (#3807) Fixes the following compiler warning: ``` /__w/allwpilib/allwpilib/hal/src/main/native/sim/Notifier.cpp:323:21: error: 'char* strncpy(char*, const char*, size_t)' specified bound 64 equals destination size [-Werror=stringop-truncation] std::strncpy(arr[num].name, notifier->name.c_str(), ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sizeof(arr[num].name)); ~~~~~~~~~~~~~~~~~~~~~~ ``` --- hal/src/main/native/sim/Notifier.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hal/src/main/native/sim/Notifier.cpp b/hal/src/main/native/sim/Notifier.cpp index 49f1c80514..c686eeaa5d 100644 --- a/hal/src/main/native/sim/Notifier.cpp +++ b/hal/src/main/native/sim/Notifier.cpp @@ -320,7 +320,7 @@ int32_t HALSIM_GetNotifierInfo(struct HALSIM_NotifierInfo* arr, int32_t size) { static_cast(getHandleIndex(handle))); } else { std::strncpy(arr[num].name, notifier->name.c_str(), - sizeof(arr[num].name)); + sizeof(arr[num].name) - 1); arr[num].name[sizeof(arr[num].name) - 1] = '\0'; } arr[num].timeout = notifier->waitTime;