Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-21 01:01:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ntcore] Cache GetEntry(name) values (#4531)

Browse Source 
These are typically cached at higher levels anyway, but cache at lowest
C++ layer as well for consistency with NT3.
This commit is contained in:
Peter Johnson
2022-10-27 23:34:58 -07:00
committed by GitHub
parent dcda09f90a
commit 1c3c86e9f1
2 changed files with 17 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ntcore/src/test/native/cpp/LocalStorageTest.cpp
View File

@@ -63,6 +63,14 @@ TEST_F(LocalStorageTest, GetEntryEmptyName) {
EXPECT_EQ(storage.GetEntry(""), 0u);
}
TEST_F(LocalStorageTest, GetEntryCached) {
EXPECT_CALL(network, Subscribe(_, wpi::SpanEq({std::string{"tocache"}}),
IsPubSubOptions({})));
auto entry1 = storage.GetEntry("tocache");
EXPECT_EQ(entry1, storage.GetEntry("tocache"));
}
TEST_F(LocalStorageTest, GetTopicName) {
EXPECT_EQ(storage.GetTopicName(fooTopic), "foo");
EXPECT_EQ(storage.GetTopicName(barTopic), "bar");