Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-21 01:01:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ntcore] Fix string array value comparison (#5745)

Browse Source 
It did not correctly check size prior to checking size=0.
This commit is contained in:
Peter Johnson
2023-10-10 00:27:56 -07:00
committed by GitHub
parent ff1849052e
commit 1d23513945
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
ntcore/src/main/native/cpp/Value.cpp
View File

@@ -389,6 +389,9 @@ bool nt::operator==(const Value& lhs, const Value& rhs) {
lhs.m_val.data.arr_double.size *
sizeof(lhs.m_val.data.arr_double.arr[0])) == 0;
case NT_STRING_ARRAY:
if (lhs.m_val.data.arr_string.size != rhs.m_val.data.arr_string.size) {
return false;
}
if (lhs.m_val.data.arr_string.size == 0) {
return true;
}