Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-07-06 03:31:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enable log macros to work with no args (#4475)

Browse Source 
This is enabled by the C++20 __VA_OPT__ feature.
Uses of "{}" format string were updated.
Some warning suppressions were required for older clang versions.
Also improve codegen of wpi::Logger::Log(), frc::ReportError(), and frc::MakeError();
these generate better and less redundant code if they use fmt::string_view for the
format string instead of templating on it.
This commit is contained in:
Tyler Veness
2022-10-19 10:49:27 -07:00
committed by GitHub
parent 878cc8defb
commit 1fc098e696
70 changed files with 373 additions and 338 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
roborioteamnumbersetter/src/main/native/cpp/DeploySession.cpp
View File

@@ -79,7 +79,7 @@ bool DeploySession::ChangeTeamNumber(const std::string& macAddress,
session.Open();
DEBUG("SSH connection to {} was successful.", ip);
SUCCESS("{}", "roboRIO Connected!");
SUCCESS("roboRIO Connected!");
try {
session.Execute(fmt::format(
@@ -123,7 +123,7 @@ bool DeploySession::Reboot(const std::string& macAddress,
session.Open();
DEBUG("SSH connection to {} was successful.", ip);
SUCCESS("{}", "roboRIO Connected!");
SUCCESS("roboRIO Connected!");
try {
session.Execute(fmt::format("sync ; shutdown -r now"));
@@ -162,7 +162,7 @@ bool DeploySession::Blink(const std::string& macAddress,
session.Open();
DEBUG("SSH connection to {} was successful.", ip);
SUCCESS("{}", "roboRIO Connected!");
SUCCESS("roboRIO Connected!");
try {
session.Execute(fmt::format(

2
roborioteamnumbersetter/src/main/native/cpp/SshSession.cpp
View File

@@ -18,7 +18,7 @@
using namespace sysid;
#define INFO(fmt, ...) WPI_INFO(m_logger, fmt, __VA_ARGS__)
#define INFO(fmt, ...) WPI_INFO(m_logger, fmt __VA_OPT__(, ) __VA_ARGS__)
SshSession::SshSession(std::string_view host, int port, std::string_view user,
std::string_view pass, wpi::Logger& logger)