Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-22 01:11:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update for C++17 and fix MSVC warnings (#1694)

Browse Source 
* Update MSVC arguments
* Fix json allocator
* Fix simulation diamond
* Bump gtest
* Remove empty varargs in unit tests
* Replace test case with test suite
* Remove deprecation warning in optional
* Remove need for NOMIXMAX to be defined in wpilib headers
This commit is contained in:
Thad House
2019-05-31 13:43:32 -07:00
committed by Peter Johnson
parent fb1239a2ad
commit 221011494d
99 changed files with 534 additions and 398 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
simulation/halsim_ds_socket/src/main/native/cpp/main.cpp
View File

@@ -40,7 +40,7 @@ static std::unique_ptr<Buffer> singleByte;
namespace {
struct DataStore {
wpi::SmallVector<uint8_t, 128> m_frame;
size_t m_frameSize = std::numeric_limits<size_t>::max();
size_t m_frameSize = (std::numeric_limits<size_t>::max)();
halsim::DSCommPacket* dsPacket;
};
} // namespace
@@ -53,9 +53,9 @@ static SimpleBufferPool<4>& GetBufferPool() {
static void HandleTcpDataStream(Buffer& buf, size_t size, DataStore& store) {
wpi::StringRef data{buf.base, size};
while (!data.empty()) {
if (store.m_frameSize == std::numeric_limits<size_t>::max()) {
if (store.m_frameSize == (std::numeric_limits<size_t>::max)()) {
if (store.m_frame.size() < 2u) {
size_t toCopy = std::min(2u - store.m_frame.size(), data.size());
size_t toCopy = (std::min)(2u - store.m_frame.size(), data.size());
store.m_frame.append(data.bytes_begin(), data.bytes_begin() + toCopy);
data = data.drop_front(toCopy);
if (store.m_frame.size() < 2u) return; // need more data
@@ -63,9 +63,9 @@ static void HandleTcpDataStream(Buffer& buf, size_t size, DataStore& store) {
store.m_frameSize = (static_cast<uint16_t>(store.m_frame[0]) << 8) |
static_cast<uint16_t>(store.m_frame[1]);
}
if (store.m_frameSize != std::numeric_limits<size_t>::max()) {
if (store.m_frameSize != (std::numeric_limits<size_t>::max)()) {
size_t need = store.m_frameSize - (store.m_frame.size() - 2);
size_t toCopy = std::min(need, data.size());
size_t toCopy = (std::min)(need, data.size());
store.m_frame.append(data.bytes_begin(), data.bytes_begin() + toCopy);
data = data.drop_front(toCopy);
need -= toCopy;
@@ -73,7 +73,7 @@ static void HandleTcpDataStream(Buffer& buf, size_t size, DataStore& store) {
auto ds = store.dsPacket;
ds->DecodeTCP(store.m_frame);
store.m_frame.clear();
store.m_frameSize = std::numeric_limits<size_t>::max();
store.m_frameSize = (std::numeric_limits<size_t>::max)();
}
}
}